Re: [PATCH] ol.el: Fix confusing variable name

[Tim Cross <theophilusx@gmail.com>]

"Aaron L. Zeng" <me@bcc32.com> writes:

> * ol.el (org-link--open-help): Fix a confusing variable name.  No
> behavior changes.
>
> TINYCHANGE
> ---
>  lisp/ol.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ol.el b/lisp/ol.el
> index 62ea6d2bc..617223cb5 100644
> --- a/lisp/ol.el
> +++ b/lisp/ol.el
> @@ -1325,8 +1325,8 @@ PATH is the sexp to evaluate, as a string."
>    "Open a \"help\" type link.
>  PATH is a symbol name, as a string."
>    (pcase (intern path)
> -    ((and (pred fboundp) variable) (describe-function variable))
> -    ((and (pred boundp) function) (describe-variable function))
> +    ((and (pred fboundp) function) (describe-function function))
> +    ((and (pred boundp) variable) (describe-variable variable))
>      (name (user-error "Unknown function or variable: %s" name))))
>  
>  (defun org-link--store-help ()

Hi Aaron,

thanks for the patch. It looks straight forward, does seem to be less
confusing and in-line with the intention of the code and is only a tiny
change, so I think it should be applied.

Tim

-- 
Tim Cross