emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, Stig Brautaset <stig@brautaset.org>
Subject: Re: tags-todo agenda shoud not ignore DONE items
Date: Mon, 17 May 2021 00:46:59 -0400	[thread overview]
Message-ID: <87eee63r24.fsf@kyleam.com> (raw)
In-Reply-To: <87r1i69tkf.fsf@gnu.org>

Bastien writes:

> Bastien <bzg@gnu.org> writes:
>
>> Confirming this as an issue, if someone wants to fix it.
>
> This should be fixed now with 823f9744e in maint, tags-todo should now
> include DONE headings.

823f9744e looks like a regression because it removes the distinction
between `tags' and `tags-todo'.  Consider the following file

--8<---------------cut here---------------start------------->8---
* h1                                                                   :atag:
* TODO h2                                                              :atag:
* DONE h3                                                              :atag:
* h4
* TODO h5
* DONE h6
--8<---------------cut here---------------end--------------->8---

and the following configuration

  (setq org-agenda-custom-commands
        '(("1" tags "atag")
          ("2" tags-todo "atag")))

Before the above commit, 1 should show

  scratch:    h1                                                                          :atag:
  scratch:    TODO h2                                                                     :atag:
  scratch:    DONE h3                                                                     :atag:

and 2

  scratch:    TODO h2                                                                     :atag:

That matches my expectations, though the request in this thread is that
2 includes "DONE h3" as well.

With 823f9744e, both 1 and 2 show

  scratch:    h1                                                                          :atag:
  scratch:    TODO h2                                                                     :atag:
  scratch:    DONE h3                                                                     :atag:

Note the inclusion of a non-TODO entry for 2 (tags-todo).

---

James Cash sent a followup patch to this in a detached thread:

  https://orgmode.org/list/87tuvyaopv.fsf@gmail.com

As I mentioned in that thread (<87361d7p3q.fsf@kyleam.com>) and
suggested in this thread (<87d061auiw.fsf@kyleam.com>), I think tags and
tags-todo should stay aligned with agenda's m/M, with tags-todo
excluding DONE items just as M does.


  reply	other threads:[~2021-05-17  4:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13 14:40 tags-todo org-agenda-custom-command weirdness Stig Brautaset
2020-06-13 16:19 ` Stig Brautaset
2020-06-15  3:16 ` Kyle Meyer
2020-06-15 18:52   ` Stig Brautaset
2020-06-16  5:11     ` Kyle Meyer
2020-06-16  8:31       ` Stig Brautaset
2020-09-05 15:03         ` Bastien
2020-09-05 20:06           ` Stig Brautaset
2020-09-06  5:04             ` Bastien
2020-09-06  5:07       ` tags-todo agenda shoud not ignore DONE items (was: tags-todo org-agenda-custom-command weirdness) Bastien
2021-05-16 22:56         ` tags-todo agenda shoud not ignore DONE items Bastien
2021-05-17  4:46           ` Kyle Meyer [this message]
2021-05-17  5:24             ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2020-09-15 18:18 James N V Cash
2020-11-13  6:22 ` Kyle Meyer
2021-04-27 19:39   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eee63r24.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=stig@brautaset.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).