From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wAawLvmKXGGLswAAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 19:27:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uAZnKvmKXGH3bAAAB5/wlQ (envelope-from ) for ; Tue, 05 Oct 2021 17:27:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74C7E259A5 for ; Tue, 5 Oct 2021 19:27:19 +0200 (CEST) Received: from localhost ([::1]:37724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXoDm-00056A-E8 for larch@yhetil.org; Tue, 05 Oct 2021 13:27:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXnLn-0002sE-Vo for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 12:31:33 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:40680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXnLm-0002YZ-4C for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 12:31:31 -0400 Received: by mail-pg1-x536.google.com with SMTP id h3so9644916pgb.7 for ; Tue, 05 Oct 2021 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Y9u/4e0UxtNvs8JJ0exEfRBYDSfwbeH//vUsuGEv9tk=; b=OywX9Hnz8lmw3IOAiG8g1dXDiRkRFXtas48dHq1xhQJBuZoCa0JI17P5GPcSKA6e+R MA93lVRvgnFGWd4senFp7wfCuMM7bBRz6fIl1fM4VomuW4Obot2re8b1Hm+am00y/Imn R/vS8tjs7rjokuo40QmIZvcJ+RnyctvKZxUwIl63QVsUnL5O6o1vAuOi00OFuoEOrBEc 4riGJScl6pv95P1CZxCoRQw2K+kotnci6BGshT7zEGOu7jw5ueDDhbV2nbaXueLbOorb vL5wH1kZUFiNyOReQcCA+KaQiy5h89uoYRECYOvWg/CBoeRIgsJfOn2kotAOvM/Oqv1Y X0IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Y9u/4e0UxtNvs8JJ0exEfRBYDSfwbeH//vUsuGEv9tk=; b=ztOIRBHVByO88X/kgxjEx4gciveqfhIAg5zNmjVZ0ks/JWPhMglA7nPRg41gIrLHAs z0hyGYPZjGT1psQllLVQLgHx4o+MGmOJCNz01BN3sugy+nQuOnFz9Mg120DA0F/Iw9IE 6npglkWIpY5Ie6HjVmxvMmJwjW0vv1C4dhFRkbeJjCrsXYGKy9TfZ4+4obVgXpX2yIIn ZGxLNgWosDDPVWt4CeySf72s5FX9shCyprA0ibAuBOYwJ5mW+RAKdLC/wVQgHA2DR6R+ +1eMBSsec5uZLXxRoxmyQsXnDJgmblGJ7cllcPjZ9/nuOTm+ayw03EYJIVLgboQtqm2j l9aQ== X-Gm-Message-State: AOAM532DrqHpy6VKIKQJ3Vv2/l/8hhlKQZD9oLG3GmoRR8oyQ6nsMP/I pbmorK29aACEpjjx5pq3hik= X-Google-Smtp-Source: ABdhPJxGtA/oENG+GNRG4yZ8pqOTo3rSwirE5dwTdE48iswpub1YeALJdgNWNPsJjCfTc98CSjuHNQ== X-Received: by 2002:a63:4f0d:: with SMTP id d13mr16090377pgb.169.1633451488274; Tue, 05 Oct 2021 09:31:28 -0700 (PDT) Received: from localhost (211-75-42-136.hinet-ip.hinet.net. [211.75.42.136]) by smtp.gmail.com with ESMTPSA id t23sm13853867pgn.25.2021.10.05.09.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 09:31:26 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken In-Reply-To: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> Date: Wed, 06 Oct 2021 00:32:43 +0800 Message-ID: <87ee8zxwic.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=yantar92@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633454841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Y9u/4e0UxtNvs8JJ0exEfRBYDSfwbeH//vUsuGEv9tk=; b=IYFpFDtmMeH5yZ7vRFF5Y+zH3pgxVCE3AuUwTTOHeh6FmqFn0lqyBu01T+80joxCRlyyRH Sx2dbmh/zT2s/u3djVdA+O0Cb1L66YXj0Fo9sGvNgvkIZ3UQpOQ33ceYMcZ33oAgZMQp3X 6xt6frPRa3NshqmMXo9oy5decifP4cZN7d996BPEF25uH3PZitLaJVoUBrke5Heih4OXvG NS4MRSopz6IWYTDS4aY8fxSMrbDhujwEZilvXi20F6Ebd/xYFBGRX86RQQNTAef0NU6edN VXzhpzpMeR6TRk8xYs/5nRO6jnCjYt3rYRwegg3KOrmZtYyZqMWuOxBpqIURLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633454841; a=rsa-sha256; cv=none; b=aq7+CCkl7nKb5q1FNNabl0PBoxNHnaCHmmUbL53XGSRR1bLp8o9+DSsyk9B3HPiqkS1s5H 0ZLaluP42AJ1TQ0gOxiv3wQNFLN/Cfwa5FbymdGFwHhqlwyaGdWjxn/qoBLOpzcJ6oUY+L 50ycx9Pm19Wl4yPvv9re1fj7KYdUivhEDDFCJsSOOq7K9bXG1/0oItvCWNcmVS46LzDnoD 7mSKxWSEXyH2cYzCZgo4ZvfcsozUadGwQ27mJZA8qYm+GCj8HIjspN4VE8WMsniYBiby7t /UVWPyuz2O4lnS8AKR3D/8yiLJUhhavF0oFT4a9yW7abR4qJpPdG/xGqTGsNDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OywX9Hnz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OywX9Hnz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 74C7E259A5 X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: FF9BucUFoAFq --=-=-= Content-Type: text/plain Max Nikulin writes: > Thank you, Ihor. I am a user of alternative `org-goto' interface. I have > tried default one having a couple of windows in the frame (indirect > buffer for subtree, indirect for src block). It seems, previous window > configuration is restored correctly when `org-goto' is finished. > > Curiously `org-no-popup' was introduced namely for `org-goto` Thanks for the testing and digging the old commits. I tried come up with the reason why org-no-popup was used in the initial implementation. I think, the reason is avoiding situation like what you may see after running (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) So, removing the macro completely is not a good idea. I have updated the patch that should work without dropping the macro. See the attached. Best, Ihor --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-goto-Fix-window-broken-arrangement-after-399481b.patch >From 438c476066e897b1fc3d758fd48712c1846cd845 Mon Sep 17 00:00:00 2001 Message-Id: <438c476066e897b1fc3d758fd48712c1846cd845.1633451289.git.yantar92@gmail.com> From: Ihor Radchenko Date: Tue, 5 Oct 2021 20:37:02 +0800 Subject: [PATCH] org-goto: Fix window broken arrangement after 399481bad * lisp/org-goto.el (org-goto-location): Make sure that `org-on-popups' macro does not suppress the *Org Help* window pop-up. Fixes https://list.orgmode.org/e169a2f9-72b1-02bb-96c1-6e7368f646da@gmail.com/T/#t --- lisp/org-goto.el | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lisp/org-goto.el b/lisp/org-goto.el index 0a3470f54..cd832d72c 100644 --- a/lisp/org-goto.el +++ b/lisp/org-goto.el @@ -217,15 +217,16 @@ (defun org-goto-location (&optional _buf help) (condition-case nil (make-indirect-buffer (current-buffer) "*org-goto*" t) (error (make-indirect-buffer (current-buffer) "*org-goto*" t)))) - (let (temp-buffer-show-function temp-buffer-show-hook) - (with-output-to-temp-buffer "*Org Help*" - (princ (format help (if org-goto-auto-isearch - " Just type for auto-isearch." - " n/p/f/b/u to navigate, q to quit."))))) - (org-fit-window-to-buffer (get-buffer-window "*Org Help*")) - (org-overview) - (setq buffer-read-only t) - (if (and (boundp 'org-goto-start-pos) + (let ((pop-up-windows t)) + (let (temp-buffer-show-function temp-buffer-show-hook) + (with-output-to-temp-buffer "*Org Help*" + (princ (format help (if org-goto-auto-isearch + " Just type for auto-isearch." + " n/p/f/b/u to navigate, q to quit."))))) + (org-fit-window-to-buffer (get-buffer-window "*Org Help*"))) + (org-overview) + (setq buffer-read-only t) + (if (and (boundp 'org-goto-start-pos) (integer-or-marker-p org-goto-start-pos)) (progn (goto-char org-goto-start-pos) (when (org-invisible-p) -- 2.32.0 --=-=-=--