From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gOq5Dbuk0WECVwAAgWs5BA (envelope-from ) for ; Sun, 02 Jan 2022 14:12:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ABhVBruk0WHYKgAAG6o9tA (envelope-from ) for ; Sun, 02 Jan 2022 14:12:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D677611FD1 for ; Sun, 2 Jan 2022 14:12:26 +0100 (CET) Received: from localhost ([::1]:50098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n40ew-0002hg-1F for larch@yhetil.org; Sun, 02 Jan 2022 08:12:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n40eH-0002hW-1u for emacs-orgmode@gnu.org; Sun, 02 Jan 2022 08:11:45 -0500 Received: from [2a00:1450:4864:20::332] (port=43787 helo=mail-wm1-x332.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n40eE-0005Nh-NN for emacs-orgmode@gnu.org; Sun, 02 Jan 2022 08:11:44 -0500 Received: by mail-wm1-x332.google.com with SMTP id k66-20020a1ca145000000b00345fa984108so11336418wme.2 for ; Sun, 02 Jan 2022 05:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=y/yR/AkjXnAxqtt8+RoNfIGEoKPzDjzo2iLmX+9Blt4=; b=eOKv1lUjMO/LY894gT4L1rjZbBKlSDKTepPyi7mGQZ5jgXvGK3R86b2KjdmBNtbh/M pmcbm0oluV0AYLFMu4ZiZDiz3lR09uTQDOPluMf3ClAf5KhAiWosATYyZ0strcrcjHwu JqHPB8NFB7luhFNFnpuXirZE52HLtCS+kFI9hAfPTG+NSe2wNoQIhtwf+KrX+fc4I6wB 4z/K8x/tz1dEeH/yHL9iqoi+YTByM5pDWhm2Y+T6xmkSdatVWLWUG5vaKnd//72z+w8m FnWakuE8TmIPvB5JlqkCHd7tFXtf26xl7gTFYv6Lh47zHZrBrimSDrT7U7q+i3gPpZsC XBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=y/yR/AkjXnAxqtt8+RoNfIGEoKPzDjzo2iLmX+9Blt4=; b=N4kFhfDOeXacKz8GuVwS/5do0smYWwvNfQbnWmxT9TuhW3Py1SjlM5pUgc27WDbVrc YYe1DCVtQpcQ9x+ns5rZQJJ+kZVyjgJ/aMYN6a/ceCSJCH8E01+VoHCOywM7wc8TjLco vy/B2TqtDuvHI9/Unp61Zjt6uWH29AO6pv3sawKlAI+7C0wbNv8zeUFG/cAnS5oc6AG2 EfPRo9vWVll2DtHJjdzlQcmlIWLqAbcjEoeUlghoAXMhVc2cyxqxmcsg0MeVbTfXZ3Mp M9ZdGRO4KiBXNMVdQ/NS5aYHpwPR75N3AlVM8zNr1MXjfjgSoVE0NkcDbEMpxNyD4oOw WAiw== X-Gm-Message-State: AOAM530EWTn/KqDbhNkf9AfhEkxt+Q998BZnJesfjS439wnPuNKOLiv9 4Rgaxn2EfDc3Cg8u8alpobbOmF04AU0= X-Google-Smtp-Source: ABdhPJzjEkhjHpc0mBH0F/fIOOIEHj1DLqDWw7BQyGFRV8SCpnBE2rONjr8wG88u2ba+lpH9zNgEiQ== X-Received: by 2002:a1c:a54e:: with SMTP id o75mr35462635wme.121.1641129101049; Sun, 02 Jan 2022 05:11:41 -0800 (PST) Received: from localhost ([91.210.107.150]) by smtp.gmail.com with ESMTPSA id m21sm30563120wrb.2.2022.01.02.05.11.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 05:11:40 -0800 (PST) From: Ihor Radchenko To: emacs-orgmode@gnu.org Subject: [PATCH] make test: Make failure results more verbose Date: Sun, 02 Jan 2022 21:12:59 +0800 Message-ID: <87ee5q5lic.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::332 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=yantar92@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641129146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=y/yR/AkjXnAxqtt8+RoNfIGEoKPzDjzo2iLmX+9Blt4=; b=pVifvYfKHPwbIGdl0VY9qr/sGyDRWIqDYOtz/dHwyd+m0x2RmZ8sd1am1RCxwTBh4YMUzV 9OIrX10nA9XKHVsRctfh8QAGz7HeplmQQEpoVZEy5wKW0Rq6/67mIhnL1zjEX0u9QSItdS E3A+iXnHTYJbzDo4DZIt61Swv4/ze6Ga3wPFtiX3lo717Fs2XrHKbRkfhCY+qUI32oCHUA rIipLnIf/bNQLcFaMLYCsT6n1vnmC7QxSFZzH6H37ojjsObeZt0GSO9WdyDZm8ZoVl4o21 pQJo1PzP7qZvQW3lE+1Wc5D7CwXPoo6zX583GhalL3UTrC6CE+YF8Ne09vYHNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641129146; a=rsa-sha256; cv=none; b=a9bzYcpMGg50to3tD/fo6pGEGO0Cjf/uJjgOT3nkhtz7T6g8vTxTd8r6rKGjZjgPFgWr8c t0XVyfWcYem7Ogw0vFbKFwE7d60OtyGVrn8acIY5b5+V18y11ouClSdka88MY3Q0vnYR6C 2pQCeOtuh9DQxtUUq6liU5+aviH0xcmvqDYgEUCkZMnszVoTW2t+WOXzinDseZwHsptJJ5 j2ujphq/UHnW++D/9lK8U0u7+IHtEZgvKWEPU2pfONdvRRXbpGtMm5QymZ3CadH0F5ef0S P20O8Klf+j+LdRYX8XfKYIpo+t2JhWCMdAyTPIIPnEtkMDCcmxGdfLrhbognoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOKv1lUj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.08 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOKv1lUj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D677611FD1 X-Spam-Score: -6.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: Mzp0/iBSuf97 --=-=-= Content-Type: text/plain Hi, In newer Emacs, ERT is capable of providing more info about FAILED tests. Maybe we can enable this option by default in the Org test suite? Best, Ihor --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-make-test-Make-failure-results-more-verbose.patch >From 5e78a588a73871e54177080b3a6c9667f97500be Mon Sep 17 00:00:00 2001 Message-Id: <5e78a588a73871e54177080b3a6c9667f97500be.1641129033.git.yantar92@gmail.com> From: Ihor Radchenko Date: Sun, 2 Jan 2022 21:08:11 +0800 Subject: [PATCH] make test: Make failure results more verbose * mk/default.mk: New option BTEST_ERT_VERBOSE controlling verbosity of ERT results. The new default is verbose. * mk/targets.mk (check test test-dirty): Obey BTEST_ERT_VERBOSE Starting from https://git.savannah.gnu.org/cgit/emacs.git/commit/etc/NEWS?id=8be9d4a1568c34aed753b085d5d33daef5dfa797 ERT can output more verbose failure results. More verbose sounds like a better default. --- mk/default.mk | 2 ++ mk/targets.mk | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/mk/default.mk b/mk/default.mk index c8a15bdd2..c49950c04 100644 --- a/mk/default.mk +++ b/mk/default.mk @@ -32,6 +32,8 @@ TMPDIR ?= /tmp testdir = $(TMPDIR)/tmp-orgtest # Configuration for testing +# setup ERT vebosity +BTEST_ERT_VERBOSE = yes # add options before standard load-path BTEST_PRE = # add options after standard load path diff --git a/mk/targets.mk b/mk/targets.mk index 6de77b1e6..937bb82bc 100644 --- a/mk/targets.mk +++ b/mk/targets.mk @@ -103,7 +103,11 @@ vanilla: check test:: compile check test test-dirty:: -$(MKDIR) $(testdir) +ifeq ($(BTEST_ERT_VERBOSE),yes) + TMPDIR=$(testdir) EMACS_TEST_VERBOSE=yes $(BTEST) +else TMPDIR=$(testdir) $(BTEST) +endif ifeq ($(TEST_NO_AUTOCLEAN),) # define this variable to leave $(testdir) around for inspection $(MAKE) cleantest endif -- 2.34.1 --=-=-=--