emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "David Lukeš" <dafydd.lukes@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: More robust CSL-JSON date parsing in oc-basic
Date: Tue, 22 Feb 2022 20:01:27 +0100	[thread overview]
Message-ID: <87ee3u3euw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAEPTPExcZKGAm3v-brzezfCwMM4h3hQtOq+89Qg+5ULJq1K4Yw@mail.gmail.com> ("David Lukeš"'s message of "Tue, 22 Feb 2022 00:48:27 +0100")

Hello,

David Lukeš <dafydd.lukes@gmail.com> writes:

> -                                        (car (split-string date "-")))
> +                                        (replace-regexp-in-string
> ".*?\\([0-9]\\{4\\}\\).*" "\\1" date))
> +

[...]

> Let me know which of these changes -- if any -- seem acceptable, and
> whether they qualify as tinychange, and I'll happily submit a proper
> patch :)

All changes sound good. Please use `rx' for the regexp matching the
year.

This is a tinychange. I think this can be applied to the bugfix branch.

Thanks!

Regards,
-- 
Nicolas Goaziou


  reply	other threads:[~2022-02-22 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 23:48 More robust CSL-JSON date parsing in oc-basic David Lukeš
2022-02-22 19:01 ` Nicolas Goaziou [this message]
2022-02-25 13:20   ` David Lukeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee3u3euw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=dafydd.lukes@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).