From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gOacC5fY02IRBwAAbAwnHQ (envelope-from ) for ; Sun, 17 Jul 2022 11:38:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WMFPCpfY02JdZAAAG6o9tA (envelope-from ) for ; Sun, 17 Jul 2022 11:38:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 993AB211AF for ; Sun, 17 Jul 2022 11:38:30 +0200 (CEST) Received: from localhost ([::1]:34486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oD0jN-0004xI-7O for larch@yhetil.org; Sun, 17 Jul 2022 05:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD0im-0004xA-Kv for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 05:37:52 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:37426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oD0il-0004Hg-1l for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 05:37:52 -0400 Received: by mail-pl1-x636.google.com with SMTP id f11so6670498plr.4 for ; Sun, 17 Jul 2022 02:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=bx67gNimR0gd0+/Gzzg8GzLV3MBOaZfYX9GrRJbWMts=; b=VlO9KXn1q/ZnDwi9MdUw/kEqWq7EcB0g+dASmCuws/Ga7qXO7D1QFLVf9KhRRMMPWM qsIOTppSniZJbhAlXo5j9SurqB8HGhRuuBcryuww3JCf/ZeVdCjCvY+eS0fGKhv1fYZS 6ppKPVZgsoIuRjSW8NOpQsznfMhst6fujNrq8+Hu9GRDkeHCLnaQED17MbjS+IC6BRoG p4XC27PZ5eJF9zdlzhHt1sle5an8ilb0TElCjFsM6VMAiLZtIVq1jihvuVv4WW8Q5uhc hg2ykUzGfiASIyoVIXiAJEtk9sxwaWFujHC/UHNd520b57qZlKXPhvNoELiDa9iuUVym sVEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=bx67gNimR0gd0+/Gzzg8GzLV3MBOaZfYX9GrRJbWMts=; b=xlMsoNyc7SzgSauAgdzg2EX5OUXIi+MXludRz0ZXhqKaGESZtRNNTeJ/IL9HvXwSuW Eb/XgeODtNpRb/yDM1f9R/hcaNzHzjngkS69X0K7/I2rwC/QLwxHGPO+rh8l3kjYoy9N qTA7lFVW6faV8sf0zrbb5FC5qw54VfFCzCPChCUifH4eUxxKo+ptJ3DS7Us2v2TIJKXK c5qy6Pctm+HQsgIkDe+WtVpSdku0LUOq+Okup+/fCF5Ep41RS+vWdq5HZoe3Q9Rv+Z9M RH5ERmrOxLXPLLMW5Zijud+Tn4qkyHdrVurnGDBCeReLmkHCf4t2yB5+yY0Pu2WDbQIj c1pA== X-Gm-Message-State: AJIora/9FFO99n5dNwvHzv9Gox8Q5u5OvRlfoBB3C0KYo5u8rEwzZWQm PEgZMpp0m03yGfbQtmEzrl0= X-Google-Smtp-Source: AGRyM1uTCAf6X8LypL+SVRa1TMf6Aaq6wt0DF3Bux7dPV9PtnVCebCG7ClE5aYOREPn7sQGilsS85g== X-Received: by 2002:a17:90b:1e53:b0:1f0:2a08:e101 with SMTP id pi19-20020a17090b1e5300b001f02a08e101mr26532596pjb.208.1658050669479; Sun, 17 Jul 2022 02:37:49 -0700 (PDT) Received: from localhost ([2409:8a70:2bd:4d0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id s13-20020a170902b18d00b0016c35b21901sm6849807plr.195.2022.07.17.02.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 02:37:48 -0700 (PDT) From: Ihor Radchenko To: Max Mikhanosha Cc: emacs-orgmode@gnu.org Subject: Re: PATCH: [PATCH] Allow bulk agenda actions to take log notes In-Reply-To: References: Date: Sun, 17 Jul 2022 17:38:51 +0800 Message-ID: <87edyk84es.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=yantar92@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658050710; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bx67gNimR0gd0+/Gzzg8GzLV3MBOaZfYX9GrRJbWMts=; b=op4A+miY5aUR7JnRLl0rCDpqQvVf59lr6j31RpdyPGBeGM7s9anoSOxXWT07nBMU+l6wjp ylbxoH+wLwr9G5UfTknAniPX81pGlKvKarmvHHbgGcbpBPvqrI28X2w1mU+XRSig8WQtgf TdOFcjfs2ouvKPCzg6g9M+XmIYS7E0bjNlsCIX7i4e+upGJ9hadyBxvEYkz/0Svu24mA9Q 9XhYjkW+LLILEGZKiA7yCxTEvgp8XdlJYSvAZAzr9fYWO+wzTx00lg91QAwpMB5aFaaFlx t7+F6GO+ltCo/Xxlz+YnrBQiT6KxupKsxL4mOEGZvIWpQeLDi7M/xMaXodeIUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658050710; a=rsa-sha256; cv=none; b=jjPbNm1TPiRkHRTVxxoc4rWxRlZSrJRgjuabxcwKbDQZ82jrxnz6TQTTsjV/V58Fne8mNA RXTMxMsZ0JK2O52CE+9snbBBoqORPDbZQuiPYSWaCffqk2uhhE819Bl+RHt15l8RstvEKT Nw8im1BvveeCuRifCwukNUTFeHPHnmp4BPSqL/enqG4w14WgA+cFOkSEJhDKDqGuWXI6Vd HvkPmrwD7E6MFgRVf73KhDHLug6lv24f0ZkLllblYSUB1KHwlCGPfkJ81MKPVVfZtrvei5 JxW7SltnVQFm9A+5/xZWX8CufPOJBTUKvPZg8K6zgPhSUAPImaLC2LiNrfhmZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VlO9KXn1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.43 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VlO9KXn1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 993AB211AF X-Spam-Score: -5.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: uekaXtfyq54f Max Mikhanosha writes: > Currently org-agenda-bulk-action is completely broken if anything tries to > take a log note during the action, this patch fixes it by storing log note > setup variables in a list, and then taking one log note, and duplicating it > over all affected items. Thanks for the patch! I tried to test the patch and ran into an issue using the following recipe: 1. Create /tmp/bug.org with the following contents: #+TODO: TODO(t) | DONE(d@) * TODO this is test * TODO this is test * TODO this is test * TODO this is test * TODO this is test * TODO this is test * TODO this is test * TODO this is test 2. Open Emacs from Org git repo folder containing the patch applied onto the latest main branch: make clean; make autoloads; emacs-29-vcs -Q -L ./lisp /tmp/bug.org 3. Open agenda via M-x org-agenda < t 4. Move point to one of the TODO entries and change the toto state to DONE: t DONE 5. The log window will pop. Enter "something" C-c C-c 6. Mark several TODO entries in the agenda 7. Try to bulk-mark them DONE: B t DONE 8. Observe no window popup, empty notes, and some entries not being marked as done in the agenda buffer. Best, Ihor