From: Ihor Radchenko <yantar92@posteo.net>
To: Jeremie Juste <jeremiejuste@gmail.com>
Cc: "Greg Minshall" <minshall@umich.edu>,
"Johan Tolö" <johan@toloe.se>,
emacs-orgmode@gnu.org, "Berry, Charles" <ccberry@health.ucsd.edu>
Subject: Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)]
Date: Thu, 08 Dec 2022 09:07:53 +0000 [thread overview]
Message-ID: <87edtantzq.fsf@localhost> (raw)
In-Reply-To: <87sfhqudks.fsf@gmail.com>
Jeremie Juste <jeremiejuste@gmail.com> writes:
> Many thanks to you all for your feedback.
> From 1ad16ffb9, I have restored the expected output in R. that is.
>
>
> #+NAME: example-list
> - simple
> - not
> - nested
> - list
>
> #+BEGIN_SRC R :var x=example-list
> x
> #+END_SRC
>
> #+RESULTS:
> | simple |
> | list |
I am not sure if I like the approach you used in the commit.
- (unless (listp (car value)) (setq value (list value)))
+ (unless (listp (car value)) (setq value (mapcar 'list value)))
In the above, you are transforming (val1 val2 val3 ...) list into
((val1) (val2) (val3) ...).
Does it make sense from the point of view of R code?
AFAIU, the current ob-R implementation converts lists into R tables,
which is not accurate? Would it make sense to convert Elisp lists into R
lists directly?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-08 9:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 14:34 [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)] Johan Tolö
2022-12-05 2:43 ` Greg Minshall
2022-12-05 10:29 ` Johan Tolö
2022-12-05 11:21 ` Jérémie Juste
2022-12-05 18:57 ` Berry, Charles
2022-12-06 0:41 ` Greg Minshall
2022-12-06 4:31 ` Berry, Charles
2022-12-06 6:52 ` Greg Minshall
2022-12-05 2:49 ` Greg Minshall
2022-12-06 22:11 ` Jeremie Juste
2022-12-07 1:31 ` Greg Minshall
2022-12-07 1:53 ` William Denton
2022-12-07 12:16 ` Ihor Radchenko
2022-12-07 21:08 ` Jeremie Juste
2022-12-08 9:07 ` Ihor Radchenko [this message]
2022-12-08 12:42 ` Greg Minshall
2022-12-08 12:51 ` Ihor Radchenko
2022-12-08 13:33 ` Greg Minshall
2022-12-10 12:31 ` Johan Tolö
2022-12-11 8:51 ` [FR] Allow passing nested list structures to variables in src blocks (was: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)]) Ihor Radchenko
2022-12-11 15:31 ` [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)] Jeremie Juste
2022-12-12 9:47 ` Ihor Radchenko
2022-12-12 12:17 ` Greg Minshall
2022-12-12 12:27 ` Ihor Radchenko
2022-12-13 13:29 ` Johan Tolö
2022-12-14 2:53 ` Greg Minshall
2022-12-15 8:51 ` Johan Tolö
2022-12-15 17:50 ` Greg Minshall
2022-12-29 16:00 ` Bastien Guerry
2022-12-29 23:52 ` Berry, Charles
2022-12-30 9:25 ` Bastien
2022-12-31 12:42 ` Ihor Radchenko
2022-12-30 9:24 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edtantzq.fsf@localhost \
--to=yantar92@posteo.net \
--cc=ccberry@health.ucsd.edu \
--cc=emacs-orgmode@gnu.org \
--cc=jeremiejuste@gmail.com \
--cc=johan@toloe.se \
--cc=minshall@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).