From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SIf1HJTbGmS3CQEASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 11:42:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2Ff/G5TbGmQd8QAAG6o9tA (envelope-from ) for ; Wed, 22 Mar 2023 11:42:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21F9A11FB8 for ; Wed, 22 Mar 2023 11:42:27 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Nhh+Cc1W; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679481748; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7tDxnaq8Pudn8JQ8hW82UzDx2t+haKzFB00zOn0pM/U=; b=QLgRrgiru22npO4iJCeW38nEK7VGpjek9NpTQRSOk0zaxPbG68nG67RhZAMdKyLeI8JFqv 7wRG67s8kHFYGJKlStHgDeoYQexgNA2NoFhApYjICM3fLRo36D6UFStOKinwQeaW3eD4G5 Mv7tnIpZhwAe2NcqgYHBA7GJlGeCFnarsCr6i6+XA+6O2XbpIvYzAeXCPLurXKpg4XK3Ma Q3TvoJ/GV2yOAKz4I2oaZejC9axfbYmcEp5F0hThbTgRPIl/z6WZ/AbNqOALj2PdxXDWh9 KIt7+c/VtMDJr+fMaRJ9Fay9qYBubjQu3896iEgs0XIv1Lh7OZ4nQQFE4KktFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679481748; a=rsa-sha256; cv=none; b=V1eEbcCmRKJuryI/ESiwoF91xTaUIyX7bKq4UIf8JGMNxMKK+K8DOrkRgurlk8EnO1ttcn UmurZesJcEu6gqnYyZjYC51vKuOQywh5T/UdFe18h8rWWShkB9wJduJANhzP/noiq3/1Pc wqSXDStuPnxUy6B03CRHSAhqf+PfAX1plW1WddwmF1VxuHGZN3sQBr8JI6lJT3eA/9PMkP tVsLmEBWEA/YIaURl1JGCAa3aI8sbmQChPMb19Qoi0JZFuWFkOOZsvhQ874Y6TKLc7htsy uqztAa99ImALpx52q30F/lXtmXcCERPcEt3xp2KLk7hwpLi4zH3vAzzG/hdLfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Nhh+Cc1W; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pevuZ-0001az-0K; Wed, 22 Mar 2023 06:41:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pevuW-0001an-Fg for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 06:41:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pevuU-0001rI-IL for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 06:41:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D04922407C9 for ; Wed, 22 Mar 2023 11:41:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679481696; bh=I55TDV4B0m/AHPOelSLwNObrMp3VqF0s+OIzxJ/kaPg=; h=From:To:Cc:Subject:Date:From; b=Nhh+Cc1W6xMFH0A6IWZ9oWphs9zd1pgfVdVSVuvQWCm6LhFjGFgT0qd0vEHaDcfEV /twDoUnx/Quy73K4OGhONFhedbFwGi5lyh9ak4j0ueCf6LtSZxPpyxPVwggdStxQIw H0d7s8jcKD3AWITnuZLXt8gpRGC1D0HXW5Ukt55PuJddcdHqmE33BjyCqG87kwo7Yw 5aUAAJTfDTwTNwH5ZVPlXP2NPSGQ9jmfYpjNwT/1k3YHCq1KFCkk72f5LIguJstH+U MgzqPbV+QchSKgS3vOd8ep7jCaoYRSEO+vmO67TT4C0rAuHoLWCCFaUTe2lEMl7ses HBN8+w1qqTk5A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhQ4v08fKz6tn7; Wed, 22 Mar 2023 11:41:34 +0100 (CET) From: Ihor Radchenko To: Zelphir Kaltstahl Cc: Bruno Barbier , emacs-orgmode@gnu.org, Bastien Subject: Re: [PATCH] lisp/ob-scheme.el In-Reply-To: <9710552a-601b-8a0c-1c30-4bb2263c2739@posteo.de> References: <9eab60bc-9b82-e037-d63b-3d879573ae32@posteo.de> <87v8jceihi.fsf@localhost> <7fc63848-d6d3-80e0-ae78-00967990813d@posteo.de> <64079614.170a0220.5a0d3.0a23@mx.google.com> <97ee254e-72d2-2bdf-e026-78bde076f1f9@posteo.de> <6408e424.5d0a0220.8862a.2a62@mx.google.com> <87v8jaoz3u.fsf@localhost> <21ea836d-8bdf-2d0d-8515-283209f2eb1f@posteo.de> <878rg3y5he.fsf@localhost> <9710552a-601b-8a0c-1c30-4bb2263c2739@posteo.de> Date: Wed, 22 Mar 2023 10:43:27 +0000 Message-ID: <87edphoyls.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: X-Migadu-Scanner: scn0.migadu.com List-Post: X-Migadu-Queue-Id: 21F9A11FB8 X-Spam-Score: -6.57 X-Migadu-Spam-Score: -6.57 List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: KZn21uv2TA4i Zelphir Kaltstahl writes: > I've created a patch, which I will attach to this e-mail. Thanks! > Not sure it meets all formalities. For example it is not clear to me, whether I > should add the "TINYCHANGE" at the bottom of my commit message. You should, unless you have FSF copyright assignment. > Let me know, if this an OK patch or what else needs to be done or what format is > wrong, if any. See my (minor) comments below. > -- > repositories: https://notabug.org/ZelphirKaltstahl > From 51b299aa18e882681dd681acb51c9cb1b44f3b4e Mon Sep 17 00:00:00 2001 > From: Zelphir Kaltstahl > Date: Sat, 18 Mar 2023 16:06:05 +0100 > Subject: [PATCH] lisp/ob-scheme.el: Please provide a short commit summary, not just the changed file. See how we do it in https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/ > Wrapping binding definitions using `let' can lead to issues with GNU > Guile and potentially other Scheme dialects. GNU Guile will only get > to the body of the let at evaluation time, not at macro expansion > time. If the let form wraps any imports of libraries that define > macros, then those imported macros are seen too late and their > corresponding forms inside the body of the let are not > expanded. Using `define' to define bindings avoids this problem, at > least in GNU Guile. Please use double space between sentences. Also, it would be helpful to provide a link to this thread for more context. (The aim of commit message is a note for future contributors on the reason the change was made). > +(defun org-babel-expand-header-arg-vars:scheme (vars) Please use org-babel-scheme-... function name. It is the usual Elisp convention to prefix the functions as library-name-inner-function-name. The exception in org-babel is a set of special functions that must have certain name pattern. Expanding header args is not one of those special functions. > + "Expand :var header arguments given as VARS." > + (mapconcat > + (lambda (var) > + (format "(define %s %S)" (car var) (cdr var))) Is there any reason why you use %s for variable name? Previously it was formatted with escapes (using %S). Also, previous version quoted the variable value with "'". Why didn't you do it here? > + (concat (org-babel-expand-header-arg-vars:scheme vars) body)) `mapconcat' you used in `org-babel-expand-header-arg-vars:scheme' does not add trailing newline, unlike done previously. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at