emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: libreville <libreville@riseup.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Offline documentation (Org Manual info file) of org hooks is misleading
Date: Wed, 21 Jun 2023 11:35:51 +0000	[thread overview]
Message-ID: <87edm5f3oo.fsf@localhost> (raw)
In-Reply-To: <29f9dd6385bca33ae1f3ab4beb9b8c2d@riseup.net>

libreville <libreville@riseup.net> writes:

> Here's my attempt.

Thanks!

> It's my first time doing this, so kindly let me know if there's
> something I can do better!

Generally, we have instructions in https://orgmode.org/worg/org-contribute.html#first-patch

> For example, should I have replaced the subject line of this email with
> the subject in the formatted .patch?

Not necessarily. Although, adding [PATCH] to the subject would be
helpful as an indication.

> From c1fda8d0162583db709c90f01df2b8678ddc7957 Mon Sep 17 00:00:00 2001
> From: libreville <libreville@riseup.net>
> Date: Wed, 21 Jun 2023 13:04:19 +0200
> Subject: [PATCH] Delete reference to non-existent examples of hook usage.

1. I'd add "org-manual: ..." to indicate which part of Org is modified.
2. There is no need to end the subject (first) line with "."
3. You need to add TINYCHANGE cookie, unless you have FSF copyright
   assignment.
4. Changelog entry would be good, although this is a simple patch and we
   can skip it here.

Hope it is going to be a good practice :)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-06-21 11:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.0.1687332940.25718.emacs-orgmode@gnu.org>
2023-06-21  7:53 ` Offline documentation (Org Manual info file) of org hooks is misleading libreville
2023-06-21 10:26   ` Ihor Radchenko
2023-06-21 11:17     ` libreville
2023-06-21 11:35       ` Ihor Radchenko [this message]
2023-06-21 11:41         ` [PATCH] " libreville
2023-06-21 11:58           ` Ihor Radchenko
2023-06-21 11:57             ` libreville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edm5f3oo.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=libreville@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).