From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iPe8BMle6GSNZgAASxT56A (envelope-from ) for ; Fri, 25 Aug 2023 09:56:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oPWSBMle6GS+ggAAauVa8A (envelope-from ) for ; Fri, 25 Aug 2023 09:56:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B37E75D292 for ; Fri, 25 Aug 2023 09:56:56 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lTA46fbq; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692950216; a=rsa-sha256; cv=none; b=eI73T2boG9l08a+oZ2Aw+3H+TsEtHxX1LZGa62rBsMvi7uetsGstJgLjQXRo4W3bFNFVFL iNBcERwlPVcXZyjztC88t6XLD/JeFUXVEHpnNXuTFihoaf4Y74bVqw4r7h9ijdRE68YS/N RwBq2EUqFODpm4EEUb8BYwAWNSJGOY0kW5IKOhjHwMS2z7PzErEpYgFmAUVy1wW1dC/pCg obxnpTdcfwfgPaTTfI1JBpEGUmnUAUYigcQLPZwbP/TsQ6FKixMfMm13GLwy4f2/FBX+j1 PU6HPD5yjjlhlnAOxaeJ+RLg/eKQeeZQ0KkrxhC4IYDgbyA0HbuZZ9Ge3/Dzkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lTA46fbq; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692950216; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=v62lqnC06OhClPDdjQ0Do/KWGfR9yL1q6wh/YlGMssQ=; b=dj/c7aSqt3ZkMQLQTxIT9OjQ6zik/lZKAYxe0agX9aQQB5PdjrTfnU2lgZboJ60Q/5pYe9 sPUQ5V2zWCYSusGUZtXITfAGIR6LOIxF1zhPgPVh3SOKwmUpsJHoAxpFaLYLf99i+x9WUl UjiZEpG4UEZ61mIm31T1ESx3hy4GATAyOL+cT+WHSJhHVd/J0B+bQxnSJ/7qRiNTNDuOmY Hz1WnjsOORhemOTRTocYk7EG05YlYnaqX+gAXUr5EOzcR8xeC+mnvjkmAa7UeLC2F9sYPx NCFQX48cemT3cT7pNeDZUTqU48b1HREnX1MyXIFvMVivJlFTbbHNxwdREqjBkw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZRfc-0000JA-7k; Fri, 25 Aug 2023 03:55:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZRfZ-0000J2-Qs for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 03:55:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZRfW-0001p7-MG for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 03:55:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AAE69240106 for ; Fri, 25 Aug 2023 09:55:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692950143; bh=MGFk8550+scU4LRLwJkY2Lo30CvVXX6pqfHtJoFknBs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=lTA46fbqCNDTOPKTIiomiRBifK3xlr2NfkmfnfQDauItr7s46dVdvNJoOp5wvoc6Z y9buvbAu9b1lNYRfM5udwDR8AFmiYjImM9rZP+lOV4e5IrWA30Pf1/0t8tJCvSmkta mfdYL1IavlH0MDusaxMXerLeeG8uklFV5CBG0OCNyaeMFlqXNOFunrT4gCMD9Esf8X n1tF8zelv0TEADRJMcdWQ1C5W9pE4Una3kEp+VerzWtcxPUorUAlIRoWe4EyDpMtqv VD/wovTfHXmS8yEMg0LDmAo6r9fvNz9WNCFBC9QxO16b7RYyvF/uzFV/ifx/orpi2u BX8WtHj7MnWVQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RXC1W0Rmqz6v4v; Fri, 25 Aug 2023 09:55:42 +0200 (CEST) From: Ihor Radchenko To: Jens Schmidt Cc: Org-mode Subject: Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29) In-Reply-To: References: <87v8d4d5vz.fsf@localhost> <87y1i01vci.fsf@localhost> Date: Fri, 25 Aug 2023 07:56:13 +0000 Message-ID: <87edjrimhu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -6.71 X-Migadu-Queue-Id: B37E75D292 X-Migadu-Spam-Score: -6.71 X-TUID: dU01N28v3yJG Jens Schmidt writes: >> There is no universal rule when and when not to add trailing spaces in >> the tests. > > Not sure what you mean by that, but some tests rely on trailing spaces > and fail when these are not present. An explicit test on that would > make the issue more visible. See below for what I mean. The only (?) > downside is that this catches such errors in test-org.el only, and not > in all the other tests, many of which also contain (on purpose or > inadvertently) trailing whitespace: That's what I mean. For some tests, we do want trailing whitespace. For some - not. Imagine that we decide to change the test failing due to whitespace cleanup, but leave your proposed test. Then, your test may be failing, and it will be rather difficult to figure out why. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at