From: Ihor Radchenko <yantar92@posteo.net>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)
Date: Fri, 25 Aug 2023 07:56:13 +0000 [thread overview]
Message-ID: <87edjrimhu.fsf@localhost> (raw)
In-Reply-To: <c982aed3-15de-7fdb-3658-505222dbc65a@vodafonemail.de>
Jens Schmidt <jschmidt4gnu@vodafonemail.de> writes:
>> There is no universal rule when and when not to add trailing spaces in
>> the tests.
>
> Not sure what you mean by that, but some tests rely on trailing spaces
> and fail when these are not present. An explicit test on that would
> make the issue more visible. See below for what I mean. The only (?)
> downside is that this catches such errors in test-org.el only, and not
> in all the other tests, many of which also contain (on purpose or
> inadvertently) trailing whitespace:
That's what I mean. For some tests, we do want trailing whitespace. For
some - not. Imagine that we decide to change the test failing due to
whitespace cleanup, but leave your proposed test. Then, your test may be
failing, and it will be rather difficult to figure out why.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-08-25 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 11:31 [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29) Jens Schmidt
2023-08-24 11:41 ` Ihor Radchenko
2023-08-24 12:08 ` Jens Schmidt
2023-08-24 12:24 ` Ihor Radchenko
2023-08-24 12:25 ` Ihor Radchenko
2023-08-24 12:48 ` Jens Schmidt
2023-08-25 7:56 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edjrimhu.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).