From: Jack Kamm <jackkamm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] FAILED test-ob-python/session-multiline
Date: Sun, 15 Oct 2023 16:56:51 -0700 [thread overview]
Message-ID: <87edhvign0.fsf@gmail.com> (raw)
In-Reply-To: <87edjn4lfr.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
>> 1. In addition to printing `org-babel-python-eoe-indicator' after
>> execution, we could also print out a "beginning of execution"
>> indicator before execution, and then capture the output between the
>> beginning and end indicators. This is how the async session
>> execution works, and should avoid any possibility of capturing
>> prompts.
>
> This idea looks interesting. Although I would not be so sure that it
> will fix things - I have learned that comint has many edge cases we may
> not easily anticipate.
>
> For example, see the discussion in
> https://yhetil.org/emacs-devel/87y1tgqhmc.fsf@localhost/
I think this strategy could work better in ob-python than ob-shell
because ob-python sends code to a temp file and executes the whole file
at once, which should prevent prompts arising between commands.
I will probably try this approach next, if the fix I just sent here
doesn't work out:
https://list.orgmode.org/87h6mrihfg.fsf@gmail.com/
>> Alternatively, we could add an argument to
>> `python-shell-send-string-no-output' to avoid suppressing output,
>> submit it upstream to python.el, and then backport to Org to
>> support older emacs versions.
>
> If we can (eventually) remove some custom code from Org and move it to
> Emacs, it will be the best for working towards RMS request
> https://orgmode.org/list/E1kIPh1-0001Lu-Rg@fencepost.gnu.org
I started down this path here:
https://lists.gnu.org/archive/html/emacs-devel/2023-10/msg00004.html
But I haven't followed up because I started to have some doubts. In
particular, `python-shell-send-string-no-output' will terminate once it
detects a prompt, so if some output looks like it ends in a prompt then
it will terminate prematurely. Whereas in our current indicator-based
approach, the user accidentally emitting
`org-babel-python-eoe-indicator' is unlikely.
Another approach I have considered is to redirect sys.stdout from within
Python. In particular, set it to a custom class inheriting from IOBase
during the block's execution, that both prints and saves the output. I
think this approach could ultimately be more robust, and without needing
to print an ugly indicator token, but it could be complicated to do it
right.
next prev parent reply other threads:[~2023-10-15 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 12:45 [BUG] FAILED test-ob-python/session-multiline Ihor Radchenko
2023-08-26 15:47 ` Jack Kamm
2023-08-26 16:31 ` Ihor Radchenko
2023-08-27 17:55 ` Jack Kamm
2023-08-28 8:31 ` Ihor Radchenko
2023-10-15 23:56 ` Jack Kamm [this message]
2023-10-16 8:09 ` Ihor Radchenko
2023-10-15 23:39 ` Jack Kamm
2023-10-16 7:55 ` Ihor Radchenko
2024-04-02 18:27 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edhvign0.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).