From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id CH3iKR9OrmXDGwAA62LTzQ:P1 (envelope-from ) for ; Mon, 22 Jan 2024 12:14:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CH3iKR9OrmXDGwAA62LTzQ (envelope-from ) for ; Mon, 22 Jan 2024 12:14:39 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aYbeCDpJ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705922079; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=73e2Xs+t2N/3I/Zn30l0ZuU3NfBHQd6+M7+HUzClyMI=; b=jXDnKr2CsD4szg71nYYqhk1if/pWx1dwa33S2iq4nuiz/RNWOdAM0FO7+CellYqfTJCHIW M5WGl/yfNtMkDIsWS2svgV2XRwKXyYiQsSsh+14uYmHiUe2nQgrNsu/gFfo6mxbwegW8Wb 3zAzUhbWBa0sOPQpF/W8bR6zWHrAINPE6cujW8M2233D3Aa9+Xro2H0Ci2k1AtY0H2PZp+ XEJNNdWDZM57WsrZDbndCKl46UQ9+GuitEvDpgZ+uA/KqerJR705yGJ26KK+GE0nBfG9Yd p2iY5EheLKzL+GC+7RP1Yn83OKAst6TyY1qTenfGG4Ssouxbnerle3EQQdVaew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aYbeCDpJ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705922079; a=rsa-sha256; cv=none; b=ch+uAmTDJxb/c+nJCetx6lnlXEFl3IpMc8haHLEi9iY4RsMPInUZ9dcHbVwZQqD0HfqHw5 KLDLFHwUoC+BRWzh6stJQSJnF5iIZh89iDELLCx1eq63pC03zZlgWHwZrBo2Lf6FK+UMJy QlxHAV5EsU+rSEqeDJieibV3FTr/6IenRNngeL3Al6bBE1225q5+ytH+MvJAK7TtF/VHgg zZSgwfmuR7M3gAE+lVrwBgpU2f1Br8lpTNrHxxHSvBEQivFK2Gtyk0v1mWZp+zAoNa6SG6 Fv1zp0Km6/UxhRKMYf8lEzsX1QPzl5WbwOXUZ9ko8xs2R3jR2RE+wjCJVNavoQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71F7D31EFB for ; Mon, 22 Jan 2024 12:14:39 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRsFU-0003qR-Ad; Mon, 22 Jan 2024 06:13:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRsFR-0003qH-Sw for emacs-orgmode@gnu.org; Mon, 22 Jan 2024 06:13:49 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRsFO-0004Dr-QS for emacs-orgmode@gnu.org; Mon, 22 Jan 2024 06:13:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 24732240104 for ; Mon, 22 Jan 2024 12:13:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705922023; bh=WQ7RoQC54KhRAfHnVEjKcHE9YV56SYM86cDxHe5byp0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=aYbeCDpJIFq563KZPbnluSaFa/7L0PZqqDyZIa2uHyyp+BgTvx2v0ui/IfgjxJdoL DX9AmRVpwg0Bm4lKLRRW4LvCoehL/0G9Z9ACxElwURY/TdRSbrG2xsZncy3Ry8uQfk XYvF+QYVjlZRCcFzt0zrZOmrX4iE7xAE8CmkDVqVRs+IhBa7kngI/Z/64QoTv/o46J fC+2gISv/LE0dH6WPcpvLxQIKeWwZserWcY3+rNFT3UgoUSi6KA20QgL8G1ewWkuqe xleryPqRsgdLAB8G7swPFNbXhusPnByC6SZY5MhYL8SZ7aLsKMGxM92TNDMRBbQrIu K/IanafFsjR8g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TJSJk09Fjz6twn; Mon, 22 Jan 2024 12:13:41 +0100 (CET) From: Ihor Radchenko To: Ihor Radchenko , Jack Kamm Cc: Hanno Perrey , emacs-orgmode Subject: Re: Inconsistent handling of multi-line properties In-Reply-To: <87o821dv7o.fsf@localhost> References: <185742ab-1719-540e-742c-5496ff61731d@hoowl.se> <87o821dv7o.fsf@localhost> Date: Mon, 22 Jan 2024 11:17:08 +0000 Message-ID: <87ede9vcqz.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.89 X-Spam-Score: -9.89 X-Migadu-Queue-Id: 71F7D31EFB X-Migadu-Scanner: mx12.migadu.com X-TUID: 8R51Lt7AklcV --=-=-= Content-Type: text/plain Ihor Radchenko writes: >> I have noticed that properties that stretch over multiple lines using >> the :value+: syntax are ignored by org-element-property and therefore >> also by e.g. org-export-get-node-property when exporting to ics via >> ox-icalendar.el (see example below). I was wondering now whether this is >> intentional and to be expected or a bug? > 3. Change ox-icalendar to consider :LOCATION+ properties and merge them > during export. I went with this approach. See the attached tentative patch. CCing Jack - you expressed interest in ox-icalendar in the past. P.S. We need a maintainer for ox-icalendar ;) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-ox-icalendar-Add-support-for-multi-line-SUMMARY-LOCA.patch >From 84fb56dcbccc2c99be4fed172184c25cfe2a3395 Mon Sep 17 00:00:00 2001 Message-ID: <84fb56dcbccc2c99be4fed172184c25cfe2a3395.1705922024.git.yantar92@posteo.net> From: Ihor Radchenko Date: Mon, 22 Jan 2024 12:12:16 +0100 Subject: [PATCH] ox-icalendar: Add support for multi-line SUMMARY, LOCATION, and DESCRIPTION * lisp/ox-icalendar.el (org-icalendar-entry): Use `org-entry-get' to account for both PROP and PROP+ in SUMMARY, LOCATION, and DESCRIPTION properties. Use newline as accumulated value separator. * etc/ORG-NEWS (iCalendar export now supports multiline =SUMMARY=, =LOCATION=, and =DESCRIPTION= properties): Announce the breaking change. Reported-by: Hanno Perrey Link: https://orgmode.org/list/87o821dv7o.fsf@localhost --- etc/ORG-NEWS | 26 ++++++++++++++++++++++++++ lisp/ox-icalendar.el | 19 +++++++++++-------- 2 files changed, 37 insertions(+), 8 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 847ddf614..dc6886318 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -13,6 +13,32 @@ Please send Org bug reports to mailto:emacs-orgmode@gnu.org. * Version 9.7 (not released yet) ** Important announcements and breaking changes +*** iCalendar export now supports multiline =SUMMARY=, =LOCATION=, and =DESCRIPTION= properties + +Previously, it was not possible to specify multi-line location, +summary, or description when exporting to iCalendar. + +In the following example, =LOCATION= was exported as "Someplace", +ignoring the other lines. + +#+begin_src org +,* heading with multi-line property +:PROPERTIES: +:LOCATION: Someplace +:LOCATION+: Some Street 5 +:LOCATION+: 12345 Small Town +:END: +#+end_src + +Now, =SUMMARY+=, =LOCATION+=, and =DESCRIPTION+= properties can be +used to create multi-line values. + +In the above example, =LOCATION= is now exported as + +: Someplace +: Some Street 5 +: 12345 Small Town + *** ~org-agenda-search-headline-for-time~ now ignores all the timestamp in headings Previously, ~org-agenda-search-headline-for-time~ made Org agenda diff --git a/lisp/ox-icalendar.el b/lisp/ox-icalendar.el index 3dd2c88d8..f6513563d 100644 --- a/lisp/ox-icalendar.el +++ b/lisp/ox-icalendar.el @@ -643,13 +643,15 @@ (defun org-icalendar-entry (entry contents info) (let ((todo-type (org-element-property :todo-type entry)) (uid (or (org-element-property :ID entry) (org-id-new))) (summary (org-icalendar-cleanup-string - (or (org-element-property :SUMMARY entry) - (org-export-data - (org-element-property :title entry) info)))) - (loc (org-icalendar-cleanup-string - (org-export-get-node-property - :LOCATION entry - (org-property-inherit-p "LOCATION")))) + (or + (let ((org-property-separators '(("SUMMARY" . "\n")))) + (org-entry-get entry "SUMMARY")) + (org-export-data + (org-element-property :title entry) info)))) + (loc + (let ((org-property-separators '(("LOCATION" . "\n")))) + (org-icalendar-cleanup-string + (org-entry-get entry "LOCATION" 'selective)))) (class (org-icalendar-cleanup-string (org-export-get-node-property :CLASS entry @@ -658,7 +660,8 @@ (defun org-icalendar-entry (entry contents info) ;; (headline) or contents (inlinetask). (desc (org-icalendar-cleanup-string - (or (org-element-property :DESCRIPTION entry) + (or (let ((org-property-separators '(("DESCRIPTION" . "\n")))) + (org-entry-get entry "DESCRIPTION")) (let ((contents (org-export-data inside info))) (cond ((not (org-string-nw-p contents)) nil) -- 2.43.0 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--