From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KMhYDBngyGVXZgAA62LTzQ:P1 (envelope-from ) for ; Sun, 11 Feb 2024 15:56:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KMhYDBngyGVXZgAA62LTzQ (envelope-from ) for ; Sun, 11 Feb 2024 15:56:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qh9t2SGt; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707663385; a=rsa-sha256; cv=none; b=kaWVu6AEdiXMBB7gtH7mMet+182zSYll5lIe9lIO75awmExJCNbPC4pq3zILut90bKkSgo QXoxIc9HaW0h8ttkTCdwbpHSXhO9XtKRswitTP7gYMFLnzJ+BJ887e5UOpMTjgFCpCuKv1 aZgOArIKTWg3mYWGaX4SiZubZtvjFPkg6G7W97xYT17LxYn9fNf71LNGQi1VJMtUevjtRV zhieTDsNw2G+yVd7Z/52kPcNe1v+uLvRZtIsUkW+kXDWJxt/+3txnlY210j0UcPFOKw47R rbio+oFGSUzVNy6cEftnOZYgmhO+U8s/w8N0BsEXKkwijr8Iqh+B7Sp/QWuc4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qh9t2SGt; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707663385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2qNd0is+N6JXpyBFqleY1YIRDm3CyO+s7lvs4PdNCYU=; b=Iby3r8pxTY9VqAF1EK5zx3VN4J8A5QE6lIJP+2PHZ8K7FRxVPVZsg1G2Azy7PzDy/nvnmd gTwLvV3fPVTcjRmt9uQjc0kawpRS1MfntZGLyzOHVd/IGmv/DjY+PIzq9Tf0zCMKno2tEB z6xGlhfs7zzLGNB5BXWPRExJA1bcsMCbx9ARCjbvvanE3HG9tHsxwfgfdgZzCysl79MaE7 p5F056Y7ahmH8OLwecder1GypAV7iynq36KfEqkxwhXGkHgWMELtd69uY27aic9sP4rQCZ VhMDH9oSTqG9iKEf22gVtqnovMU3C4v6pWD/clvoeItrsnBufzZGwh3tQsw5xA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB1E469024 for ; Sun, 11 Feb 2024 15:56:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZBEx-0007qB-6r; Sun, 11 Feb 2024 09:55:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZBEu-0007pl-R0 for emacs-orgmode@gnu.org; Sun, 11 Feb 2024 09:55:28 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZBEs-00089I-9a for emacs-orgmode@gnu.org; Sun, 11 Feb 2024 09:55:28 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EB8F6240103 for ; Sun, 11 Feb 2024 15:55:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707663324; bh=7oC+/ObC4b3z5BpP/GJwm0BxXYDYtMm/TQkD2a6jccU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=qh9t2SGtA8iT/ypm3LbwE7Rz1kGwp0KpPcGAE4YJl3uktjaWW/ruQnKW6djibkvX2 tifwVKSmKmZPbJcJwZi8adSIT3ysLkp9bVH9L29Tf/1JLNz92a1CzSWR3DTwN7ulUa HnbtLRiUeWrFEhyp9s7sSY/UKS45rPJrDPgS+FKw3ut+RhG+LYtg8uC5RlQKO7wXDZ 4O3z6PpQ/ItCVoSb1clgUX8WJraszxWNbXVAeA6LZNkcrLJBI40yLfYMoFlhQojIWA FT8N5+Z9OOJQ3LS1GD6edTT2DFYyl6pbRPKbanyHT5IAZ/SFePwtyccmC2ZceRd+V3 LucVNn9TB4p3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TXrHG6mXvz9rxL; Sun, 11 Feb 2024 15:55:22 +0100 (CET) From: Ihor Radchenko To: Martin Marshall Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-ctags: When `ido-mode' is off, use completing-read In-Reply-To: <87frxzr44s.fsf@martinmarshall.com> References: <87frxzr44s.fsf@martinmarshall.com> Date: Sun, 11 Feb 2024 14:58:58 +0000 Message-ID: <87eddj9he5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -8.55 X-Migadu-Queue-Id: EB1E469024 X-Migadu-Spam-Score: -8.55 X-TUID: cy2EC5RS84J7 Martin Marshall writes: > Here's another patch for org-ctags.el. > > `org-ctags-find-tag-interactive' uses `ido-completing-read' for > selecting and jumping to a target. > > This patch makes it use `completing-read' instead, unless the user > enabled `ido-mode'. Thanks! I applied an alternative patch, completely removing calls to ido-mode. We are not supposed to use it at all (completing-read should be able to do it on its own) after https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fdbf441560 Handled. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at