From: Ihor Radchenko <yantar92@posteo.net>
To: Martin Marshall <law@martinmarshall.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-ctags: When `ido-mode' is off, use completing-read
Date: Sun, 11 Feb 2024 14:58:58 +0000 [thread overview]
Message-ID: <87eddj9he5.fsf@localhost> (raw)
In-Reply-To: <87frxzr44s.fsf@martinmarshall.com>
Martin Marshall <law@martinmarshall.com> writes:
> Here's another patch for org-ctags.el.
>
> `org-ctags-find-tag-interactive' uses `ido-completing-read' for
> selecting and jumping to a target.
>
> This patch makes it use `completing-read' instead, unless the user
> enabled `ido-mode'.
Thanks!
I applied an alternative patch, completely removing calls to ido-mode.
We are not supposed to use it at all (completing-read should be able to
do it on its own) after
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fdbf441560
Handled.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-02-11 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 4:55 [PATCH] org-ctags: When `ido-mode' is off, use completing-read Martin Marshall
2024-02-11 14:58 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddj9he5.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=law@martinmarshall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).