Rens Oliemans <hallo@rensoliemans.nl> writes:

> Thanks for the patch, it looks good and is an improvement over the
> somewhat terse previous version. I do have some thoughts though so will
> chime in. ...

Thanks! I have incorporated all your suggestions into the new version of
the patch (attached).

>> -  When style is not specified, default style is used
>> +  When style is not specified, default style (=nil=) specified by the
>> +  citation processor is used
>
> I am only slightly familiar with Org's citation handling, and this part
> of the manual is a bit confusing to me. I wrote a small patch on top of
> yours with something that is clearer to me, but perhaps this is unique to
> me.

Your changes look reasonable.

> PS: is such a way of including a patch (that builds upon a discussed
> patch) the best way to communicate changes? 

Yes, it is. Applying diff is easy - easier than manually editing the
changes according to comments in the email.