From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wCv0M+/dF2dY4gAA62LTzQ:P1 (envelope-from ) for ; Tue, 22 Oct 2024 17:16:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id wCv0M+/dF2dY4gAA62LTzQ (envelope-from ) for ; Tue, 22 Oct 2024 19:16:31 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ur73wvKi; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729617391; a=rsa-sha256; cv=none; b=Na4Cs4IxlO304gokWFzSZhvSzU9sJhY6BMgU9njcQdVF4ozhjrET69VzzkhiDj6CuFg2kR qg3NISUNkO5BilVRxZZefuhIEtD930L46fT8A6vCF9Iu6riKURvaYheASz0FEXg4qU38dY YAPjg0pCtEFUX1P12H8L9t+6xW6FTKC+k+QeDESRJERUg4cTr+2KY8NfXb8/+szX0NQ9OO GF5thFF9yR074UTILe2miRhfKTXAd64q/W0iiM3wAG8n/ti3dysqHLHxXaRiAva+xrgypj ACFhFJSKXNUMbY/VBzbkspAKfZ3rTKi+togj9+Jy2t797JZyOe/jYBQUiWxoiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ur73wvKi; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729617391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0yyv/vg70rBYtolJyW4DXAGkRD/x/JsBoj5L9+303P8=; b=lLeelH3N/ynekHYaXuPVNupwVEOHkjDr8dAkCsBXsXVIcW/WTx7GL5yy6O4SWx+0kHL1ow rvB4E8YmGAPsUem+O3PajRDWORVkT6ACiXKA2TMRczuk/5xY/sGruC7t3NdxBDYJoCcm3O y2ADBdQ/+TPcquakATAMPxpcMYN1j4NB7vxk3xKRANjROTiqDqu9pSLkOMnRDe79Jtin8X +4B3SiQqdDiCWJzFY6kFhJoZWhduOaarYMiD7vB9NJTdSmGgEG3sdFAPeFPLaH1u04w8Kp 1RoqFxX0USKLRun01URJHRR08x5TCnDBSQhSoFORCEbLtsCVHSB3hv/YAddC+Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63AFB81E26 for ; Tue, 22 Oct 2024 19:16:30 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ITt-0006x9-2H; Tue, 22 Oct 2024 13:15:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ITm-0006wf-Hn for emacs-orgmode@gnu.org; Tue, 22 Oct 2024 13:15:36 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ITi-0000rl-LK for emacs-orgmode@gnu.org; Tue, 22 Oct 2024 13:15:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C42E5240103 for ; Tue, 22 Oct 2024 19:15:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1729617306; bh=fOvsRAXK6+P/Z9peIsAjeZeyKw/CWiEUMEF4nYhFwX0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Ur73wvKiZ5zhB6AY3nkNk/HZ6tuJG2QfiQrSAVP7e+sbnjX0vvMMeffYjL5YBrrSg iokjd3Zg7k3qKt/bcg1zSKf2s1W+5cmvexEx7DMsQYn+DWOnrPIALDsEyZ/FbNWeuk zSBt3tdP0xPa23IkPyitzwLkxaQAZ5rOiY6ql7Lk9iFRlzpl/DXxrpAX+5a+Np4pSU 00FevQs/zi+UuHTaBhgG7ezhDZOZ4TmJCCBT/N+AFKA4EAcxebio4BLpDQ2wL3n/CG bBt0jfNaLoh1Jl4Y6jeCNdVyNDSkK1GOyiySLRICiV0jbeIkxgp2cAW+iCLXBNjqHa ODb57vwtC8wMw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XXzMG1mskz9rxN; Tue, 22 Oct 2024 19:15:06 +0200 (CEST) From: Ihor Radchenko To: Jack Kamm Cc: emacs-orgmode@gnu.org, matt@excalamus.com, jeremiejuste@gmail.com Subject: Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R In-Reply-To: <8734koert4.fsf@gmail.com> References: <87setrqs4z.fsf@gmail.com> <87wmiqigfp.fsf@localhost> <87wmi9etku.fsf@gmail.com> <87h698wml2.fsf@localhost> <87ed4b45r7.fsf@gmail.com> <875xpnrubg.fsf@localhost> <8734koert4.fsf@gmail.com> Date: Tue, 22 Oct 2024 17:16:52 +0000 Message-ID: <87ed4812ij.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.15 X-Spam-Score: -1.15 X-Migadu-Queue-Id: 63AFB81E26 X-Migadu-Scanner: mx12.migadu.com X-TUID: b7VDyjG3QjON Jack Kamm writes: > Great, thanks. I'm attaching an updated patch with the more explicit > cond clause, and rebased onto latest bugfix. I also attach a second > patch with the NEWS entry on main. Thanks! > + (t (error (format "Unrecognized prompt handling behavior %s" > + (symbol-name prompt-handling)))))) I think that `symbol-name' is unnecessary here. It will lead to cryptic error if PROMPT-HANDLING happens to be something that is not symbol (for example, a number) > +*** ~org-babel-comint-async-register~: Added argument to specify prompt handling Maybe "New optional argument controlling prompt handling" > +The new argument ~prompt-handling~ allows Babel languages to specify > +how prompts should be handled when passing output to > +~org-babel-comint-async-chunk-callback~. If equal to > +~filter-prompts~, prompts are removed beforehand, similar to the similar -> same (or did I miss something?) > +default behavior of ~org-babel-comint-with-output~. If equal to > +~disable-prompt-filtering~, then the prompt filtering is skipped. If > +unset, then the default behavior is the same as ~filter-prompts~ for > +backwards compatibility. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at