Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R

[Ihor Radchenko <yantar92@posteo.net>]

Jack Kamm <jackkamm@gmail.com> writes:

> Great, thanks. I'm attaching an updated patch with the more explicit
> cond clause, and rebased onto latest bugfix.  I also attach a second
> patch with the NEWS entry on main.

Thanks!

> +           (t (error (format "Unrecognized prompt handling behavior %s"
> +                             (symbol-name prompt-handling))))))

I think that `symbol-name' is unnecessary here.
It will lead to cryptic error if PROMPT-HANDLING happens to be something
that is not symbol (for example, a number)

> +*** ~org-babel-comint-async-register~: Added argument to specify prompt handling

Maybe "New optional argument controlling prompt handling"

> +The new argument ~prompt-handling~ allows Babel languages to specify
> +how prompts should be handled when passing output to
> +~org-babel-comint-async-chunk-callback~.  If equal to
> +~filter-prompts~, prompts are removed beforehand, similar to the

similar -> same (or did I miss something?)

> +default behavior of ~org-babel-comint-with-output~.  If equal to
> +~disable-prompt-filtering~, then the prompt filtering is skipped.  If
> +unset, then the default behavior is the same as ~filter-prompts~ for
> +backwards compatibility.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>