From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: bug#11249: 24.1.50; Overlay with face property causes	calendar
 buffer to scroll
Date: Thu, 26 Apr 2012 15:43:26 +0200
Message-ID: <87d36uip6p.fsf@gnu.org>
References: <87ehraool5.fsf@gnu.org> <20120426131911.GA3469@c3po>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:49023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SNOxq-0004KN-14
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 09:42:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SNOxj-0001qu-JG
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 09:42:29 -0400
Received: from mail-wg0-f49.google.com ([74.125.82.49]:35586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SNOxj-0001qb-AZ
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 09:42:23 -0400
Received: by wgbds1 with SMTP id ds1so378864wgb.30
	for <emacs-orgmode@gnu.org>; Thu, 26 Apr 2012 06:42:21 -0700 (PDT)
In-Reply-To: <20120426131911.GA3469@c3po> (Toby Cubitt's message of "Thu, 26
	Apr 2012 15:19:11 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Toby Cubitt <tsc25@cantab.net> writes:

> On Thu, Apr 26, 2012 at 10:59:50AM +0200, Bastien wrote:
>> Hi Matt,
>> 
>> Matt Lundin <mdl@imapmail.org> writes:
>> 
>> > Note: It seems that adding the optional argument KEEPDATE is necessary
>> > for parsing to work. With the following line instead of the one above
>> > org-read-date works as expected:
>> >
>> >  	  (org-eval-in-calendar '(setq cursor-type nil) t)
>> 
>> that's right -- I pushed this fix to master.  Thanks for reporting this
>> and for detailing the solution!
>
> Thanks for the fix!
>
> What exactly does KEEPDATE argument do? The `org-eval-in-calendar'
> docstring doesn't mention it anywhere, which is probably why I missed it
> in my patch. Looking at the code, it seems that the part about storing
> the cursor date in org-ans2 only happens for a non-nil KEEPDATE?

When keepdate is nil (which is the default), org-ans2 is updated wrt the
cursor date. At the time we set the cursor-type, we don't want to override 
org-ans2, we want to stick to the value already set.

> I'd post an update to improve the `org-eval-in-calendar' docstring, but I
> don't feel like I really understand what the KEEPDATE argument does well
> enough.

I just fixed the docstring like this:

  "Eval FORM in the calendar window and return to current window.
When KEEPDATE is non-nil, update `org-ans2' from the cursor date,
otherwise stick to the current value of `org-ans2'."

Thanks!

-- 
 Bastien