From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] ob-R.el, ox-latex.el: support for tikz graphics
Date: Tue, 26 Feb 2013 14:21:50 +0100
Message-ID: <87d2vnqkgh.fsf@gmail.com>
References: <1361731894-2738-1-git-send-email-aaronecay@gmail.com>
	<87621gfmkb.fsf@gmail.com> <loom.20130226T103317-743@post.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:52429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UAKlx-0003Fw-H8
	for emacs-orgmode@gnu.org; Tue, 26 Feb 2013 08:40:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UAKTt-0004tn-1N
	for emacs-orgmode@gnu.org; Tue, 26 Feb 2013 08:22:50 -0500
Received: from mail-wg0-f48.google.com ([74.125.82.48]:60705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UAKTs-0004tM-Pe
	for emacs-orgmode@gnu.org; Tue, 26 Feb 2013 08:22:04 -0500
Received: by mail-wg0-f48.google.com with SMTP id 16so3331023wgi.3
	for <emacs-orgmode@gnu.org>; Tue, 26 Feb 2013 05:22:04 -0800 (PST)
In-Reply-To: <loom.20130226T103317-743@post.gmane.org> (Achim Gratz's message
	of "Tue, 26 Feb 2013 10:50:17 +0000 (UTC)")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@NexGo.DE>
Cc: emacs-orgmode@gnu.org

Hello,

Achim Gratz <Stromeko@NexGo.DE> writes:

> A .tikz file usually contains a tikzpicture environment that wraps around the
> actual tikz code.  It produces a box just like includegraphics does, only that
> it is normal LaTeX code, and so you need \include to read it.

Ok, thank you.

>> If it doesn't, it may be better to implement a dedicated (or a more
>> general "input" function) formatting function that would be called from
>> `org-latex-link'.
>
> I don't understand.  What I currently need to do for TikZ is this:
>
> #+LaTeX: \begin{figure}[t]\centering
> #+LaTeX:   \input{oldModel.tikz}
> #+LaTeX:   \caption{Relative modelling error}
> #+LaTeX: \label{fig:oldModel}
> #+LaTeX: \end{figure}

  #+begin_latex
  ...
  #+end_latex

would be easier.

> With the patch that becomes much easier 

[...]

I'm not questioning the usefulness of the patch. I want to know if
`org-latex--inline-image' is the appropriate function to provide that
feature or if the feature should be provided through another function.

In particular, `org-latex--inline-image' provide options to wrap the
picture in wrapfigure environment, or to set width optional argument for
includegraphics. If it doesn't make sense in this case, the code could
as well be moved into another function, like `org-latex--input-file',
which would handle options specific for \input.


Regards,

-- 
Nicolas Goaziou