From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-core.el: fix confirm before eval when using a function
Date: Mon, 01 Jul 2013 22:26:05 +0200 [thread overview]
Message-ID: <87d2r2do2q.fsf@Rainer.invalid> (raw)
In-Reply-To: 1372705039-19522-1-git-send-email-rhansen@bbn.com
Richard Hansen writes:
> When `org-confirm-babel-evaluate' is a function, this construct:
>
> (or (when (functionp org-confirm-babel-evaluate)
> (funcall org-confirm-babel-evaluate lang block-body))
> org-confirm-babel-evaluate)
>
> will always be true -- if the function evaluates to nil, the `or' will
> evaluate to the value of `org-confirm-babel-evaluate', which is
> non-nil.
Indeed, thanks for catching it. This had actually been fixed before in
exactly the same way, then replaced by a cond form and then replaced
again (wrongly) with an or form… I should have looked at the history of
that code more closely.
Fixed in maint and master.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables
prev parent reply other threads:[~2013-07-01 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 18:57 [PATCH] ob-core.el: fix confirm before eval when using a function Richard Hansen
2013-07-01 20:26 ` Achim Gratz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2r2do2q.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).