emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: [bug?][ob-core] using remove-if
Date: Tue, 30 Jul 2013 02:09:47 +0200	[thread overview]
Message-ID: <87d2q07vsk.fsf@gmx.us> (raw)

Hi,

Regarding this commit:

          commit 3142297d69f6063221215757a3ba9c74adcf3e43
          Author: Eric Schulte <schulte.eric@gmail.com>
          Date:   Fri Jul 26 11:48:51 2013 -0600.

remove-if is introduced in ob-core.el:

	    (setf (cdr (assoc param params))
		  (remove-if (lambda (pair) (equal (car pair) name))
			     (cdr (assoc param params))))
	    (setf params (remove-if (lambda (pair) (and (equal (car pair) param)
						   (null (cdr pair))))

I personally don't care too much if Org depends on cl, but it breaks
async export since cl is usually not loaded.

Thus, I guess it should (i) either be changed to org-remove-if or
there should be an autoload to remove-if.  I don't feel very
comfortable about messing with ob-core ob-core and I don't know if
org-remove-if is a drop-in replacement of remove-if so I havne't made
a patch.

–Rasmus

-- 
Don't panic!!!

             reply	other threads:[~2013-07-30  0:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30  0:09 Rasmus [this message]
2013-07-30  0:28 ` [bug?][ob-core] using remove-if Eric Schulte
2013-07-30  0:56   ` Rasmus
2013-07-30  1:02   ` Aaron Ecay
2013-07-31 15:37     ` using cl-lib Was: " Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2q07vsk.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).