From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] lisp/org.el (org-open-at-point): prioritize link
Date: Thu, 27 Feb 2014 23:40:00 +0100
Message-ID: <87d2i8qiwv.fsf@gmail.com>
References: <CAA01p3pNBFfdTh870gR7J+xchzFiPS11+54BW67S7t0SVDbpGw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WJ9cI-00016g-Jz
	for emacs-orgmode@gnu.org; Thu, 27 Feb 2014 17:39:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WJ9cA-0004Hx-7L
	for emacs-orgmode@gnu.org; Thu, 27 Feb 2014 17:39:46 -0500
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:33046)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WJ9cA-0004HP-16
	for emacs-orgmode@gnu.org; Thu, 27 Feb 2014 17:39:38 -0500
Received: by mail-wi0-f176.google.com with SMTP id hi5so54931wib.3
	for <emacs-orgmode@gnu.org>; Thu, 27 Feb 2014 14:39:36 -0800 (PST)
In-Reply-To: <CAA01p3pNBFfdTh870gR7J+xchzFiPS11+54BW67S7t0SVDbpGw@mail.gmail.com>
	(Oleh's message of "Thu, 27 Feb 2014 14:28:57 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Oleh <ohwoeowho@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>

Hello,

Oleh <ohwoeowho@gmail.com> writes:

> Can someone check this patch and commit it.
> It allows to open links that look like this:
>
>     [[id:164552ee-b92d-4af6-9570-60d039876fac][=foobar=]]

I applied a generalization of your patch. Thank you.

While I'm at it, here are a few comments.

> +	   (parent (plist-get (cadr context) :parent))

This is too low level. It should really be:

  (parent (org-element-property :parent context))

> +	   (context (if (eq (car parent) 'link) parent context))

Same here. The preferred syntax is:

  (context (if (eq (org-element-type parent) 'link) parent context))


Regards,

-- 
Nicolas Goaziou