Bug: Activating org-mode in any buffer recenters (unrelated) selected window. [8.2.6 (release_8.2.6-6-gfc37d1 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

Bug: Activating org-mode in any buffer recenters (unrelated) selected window. [8.2.6 (release_8.2.6-6-gfc37d1 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

[Nicolas Richard]

The function `org-overview' calls `recenter' without checking if the
current buffer is actually in the currently selected window. Moreover,
turning on org-mode calls `org-overview' (I guess depending on the
configuration). IOW, turning on org-mode programmatically (e.g. via
find-file-noselect) will recenter whatever window is currently selected.
That's unexpected.

I noticed that because I recently tried org-notify, which uses
find-file-noselect, and the behaviour was very distracting to me. (Side
question : do people live with that or is it just me seeing the weird
behaviour ?)

Anyway, I would suggest to simply remove the call to recenter because I
don't understand why it's there. OTOH if it's there for a reason, then I
suggest something along the line of:
(when (eq
       (current-buffer)
       (window-buffer
        (selected-window)))
  (recenter '(4)))

(but then, why the interactive-looking argument ?)

While I am at it, I don't quite understand why (goto-char) is used
*after* recenter (also, why not just save-excursion ?)

Since there are many things I obviously don't understand, I'm not
posting an actual patch but I can do that if someone wants it.

-- 
Nico.

Re: Bug: Activating org-mode in any buffer recenters (unrelated) selected window. [8.2.6 (release_8.2.6-6-gfc37d1 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

[Bastien]

Hi Nicolas,

I removed the call to `recenter' and to `goto-char'.

Thanks for reporting this,

-- 
 Bastien