From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption for minted listings Date: Sat, 23 Aug 2014 20:44:36 -0400 Message-ID: <87d2bqpvgr.fsf@gmail.com> References: <1408779394-11436-1-git-send-email-aaronecay@gmail.com> <87ha13dm3v.fsf@nicolasgoaziou.fr> <87oavbostg.fsf@gmail.com> <87a96uep52.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLLvM-0005Pt-2P for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 20:44:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLLvD-0000bF-1a for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 20:44:48 -0400 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:48662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLLvC-0000bB-TN for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 20:44:38 -0400 Received: by mail-qc0-f177.google.com with SMTP id x13so12423103qcv.22 for ; Sat, 23 Aug 2014 17:44:38 -0700 (PDT) In-Reply-To: <87a96uep52.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou , emacs-orgmode@gnu.org Hi Nicolas, 2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen: >=20 > Aaron Ecay writes: >=20 >> It=E2=80=99s not adding any new functionality to the exporter, >=20 > Well, it is, since "captionof" command doesn't exist in Org default > packages. I guess this was unclear. What I meant was that the patch is not introducing any new expressivity on the org-mode side. There is a situation (described in my previous mail) that is a valid combination of org configuration variables and buffer text, which produces inconsistent latex output. This patch fixes that. >=20 >> but rather covering one particular combination of already-existing >> options (caption provided, :float nil, org-latex-listings =3D minted) >> that does not produce sensible output presently. Should I fix the >> nil/no issue and send a new patch? >=20 > With your patch, when encountering the combination above, the export > back-end will introduce a "captionof" command, which requires loading > "caption" package with a specific option (i.e., compatibility=3Dfalse). Why is the compatibility=3Dfalse option needed? I can=E2=80=99t figure this out. >=20 > If this is explained nowhere, it is hardly a fix. If you document it, > you introduce support for "caption" package in Org. Is there a strong > reason for that? =E2=80=9CPretty=E2=80=9D source code export in all cases requires adding ce= rtain packages to the default, as explained in the docstring of =E2=80=98org-latex-listing= s=E2=80=99. The patch adds discussion of the caption requirement there, so there is no =E2=80=9Cif=E2=80=9D about the documentation. I don=E2=80=99t understand what you=E2=80=99re saying about introducing =E2= =80=9Csupport=E2=80=9D for the caption package. The patch uses one specific feature of the caption package in one specific place to accomplish one specific goal. There are no other changes needed anywhere else in the codebase than these couple of lines in one function (plus the documentation). The motivating reason is described in my first paragraph above =E2=80=93 ma= king the output consistent for all combinations of options. Thanks, --=20 Aaron Ecay