From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [Patch] Fix date-based sorting of tags and tags-todo agenda
 views
Date: Sat, 07 Feb 2015 22:14:19 +0100
Message-ID: <87d25ltokq.fsf@nicolasgoaziou.fr>
References: <1D119613313E504D8C7FDD06E9B6DD40C951ADE8@OC11expo28.exchange.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YKCgr-00079s-4E
	for emacs-orgmode@gnu.org; Sat, 07 Feb 2015 16:13:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YKCgk-0003lw-Fv
	for emacs-orgmode@gnu.org; Sat, 07 Feb 2015 16:13:21 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:32924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YKCgk-0003lb-9G
	for emacs-orgmode@gnu.org; Sat, 07 Feb 2015 16:13:14 -0500
In-Reply-To: <1D119613313E504D8C7FDD06E9B6DD40C951ADE8@OC11expo28.exchange.mit.edu>
	(Yuri D. Lensky's message of "Sat, 7 Feb 2015 19:05:52 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Yuri D Lensky <ydl@mit.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hello,

Yuri D Lensky <ydl@mit.edu> writes:

> An example to test this problem:
>
> Evaluate:
> (setq org-agenda-custom-commands
>       '(("t" "TEST" tags-todo "tag"
>          ((org-agenda-sorting-strategy '(deadline-up))))))
> then run the view. It will not be sorted properly before the patch,
> but will be after.

Thank you. It looks good.

> I would also recommend factoring the code that I added out into
> a separate function (as it also appears almost verbatim in
> org-agenda-get-todos), but I am not sure the conventions or desire for
> this.

I agree it would be good to do that refactoring. Do you want to take
care of it in the same patch?

> From c8a7211639d9c138a3b3dcb7e3ce7c85264580f1 Mon Sep 17 00:00:00 2001
> From: "Yuri D. Lensky" <ydl@ydl.cm>
> Date: Sat, 7 Feb 2015 13:37:46 -0500
> Subject: [PATCH] Fix timestamp-based sorting of tags-based entries in agenda
>
> * lisp/org.el (org-scan-tags): Fix agenda org tags scans to properly
>   add timestamp property, completely analogously to org-agenda-get-todos.
>
> Before this fix, timestamps were ignored when sorting agenda views of
> the 'tags' and 'tags-todo' types.

You need to add TINYCHANGE at the end of the commit message. If your
patch ends up being more than 20 lines long, you'll also need to sign
FSF assignment (if not already done). See

  http://orgmode.org/worg/org-contribute.html#unnumbered-2


Regards,

-- 
Nicolas Goaziou