From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: bug#22399: org-mode fontification Date: Tue, 19 Jan 2016 09:51:18 +0100 Message-ID: <87d1sy54vt.fsf@gmx.us> References: <87oacjng36.fsf@russet.org.uk> <87ziw36khb.fsf@gmx.us> <87a8o2zrtm.fsf@russet.org.uk> <87bn8i7mha.fsf@gmx.us> <87d1syvgc7.fsf@kyleam.com> <8737tu13la.fsf__5430.1016768024$1453185240$gmane$org@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLS0m-00067R-VW for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 03:51:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLS0j-0005WF-OQ for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 03:51:36 -0500 Received: from plane.gmane.org ([80.91.229.3]:53785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLS0j-0005W6-Ha for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 03:51:33 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aLS0g-0001dS-Cz for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 09:51:30 +0100 Received: from 62.80.108.10 ([62.80.108.10]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 19 Jan 2016 09:51:25 +0100 Received: from rasmus by 62.80.108.10 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 19 Jan 2016 09:51:25 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: 22399@debbugs.gnu.org Kyle Meyer writes: > I've attached two patches against emacs-25 that would get the Org and > Emacs repos in similar states wrt font-lock-ensure. Thanks Kyle. > The first patch replaces the font-lock-ensure compatibility alias from > 6711a21f1 with the one currently used in the Org repo (from commit > e6883dd03). The new alias is limited to being called with no > arguments, but, at the moment, no Org code calls font-lock-ensure with > any arguments. I just have one concern, which is pretty theoretical. Isn’t it bad to define the alias to be font-lock-ensure since this is an existing function and people would have clear expectations of what they are calling? I realize that there’s no Emacs-25 that will not have this function (which is why it’s very theoretical). Also, if the alias were ever to point to font-lock-fontify-buffer, the signature would change compared to the expected signature of font-lock-ensure. These considerations are probably too theoretical to consider further, though. > The second patch reverts a part of 6711a21f1 that modified > org-src-font-lock-fontify-block to use font-lock-ensure rather than > font-lock-fontify-buffer. In this particular case, using > font-lock-ensure instead of font-lock-fontify-buffer fails to > highlight the source block. Cool! Cheers, Rasmus -- May contains speling mistake