From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: org-clone-subtree-with-time-shift not asking for time-shift Date: Tue, 17 Jan 2017 09:54:54 +0100 Message-ID: <87d1fm3w2p.fsf@nicolasgoaziou.fr> References: <2017-01-16T12-42-31@devnull.Karl-Voit.at> <87h94yga8e.fsf@kyleam.com> <87h94y4rpx.fsf@nicolasgoaziou.fr> <87k29uy791.fsf@kyleam.com> <2017-01-16T23-27-40@devnull.Karl-Voit.at> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTPXf-0001Ly-Ns for emacs-orgmode@gnu.org; Tue, 17 Jan 2017 03:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTPXe-0007WU-SW for emacs-orgmode@gnu.org; Tue, 17 Jan 2017 03:54:59 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:45741) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTPXe-0007W0-Jb for emacs-orgmode@gnu.org; Tue, 17 Jan 2017 03:54:58 -0500 In-Reply-To: <2017-01-16T23-27-40@devnull.Karl-Voit.at> (Karl Voit's message of "Mon, 16 Jan 2017 23:30:14 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Karl Voit Cc: Karl Voit , emacs-orgmode@gnu.org Hello, Karl Voit writes: > * Kyle Meyer wrote: >> >> Thanks. The additional check looks good, as it replaces an error with a >> more appropriate user-error and gives an error message that is a bit >> more specific. >> >> However, the re-positioning of the org-back-to-heading call seems >> problematic because the call is now wrapped in a save-excursion, but the >> downstream code expects point to be at the beginning of the heading. >> >> When I call org-clone-subtree-with-time-shift with point at the end of >> >> *** heading <2017-02-28 Wed> >> I get the following error: >> Debugger entered--Lisp error: (error "Before first headline at position 1 in buffer *temp*") > [...] >> I think this is because beg isn't set to the beginning of the heading. >> >> But given Karl's recent email saying that the changes in maint fixed his >> test cases, maybe I'm missing something ... > > I have to excuse myself: I tested not good enough: I only tested my > cases for being asked for the time-shift and not finished executing > the cases. > > You're right, I can confirm your issue. I get "Before first headline > at position 1 in buffer *temp*" as well. Fixed (hopefully) this time. Thank you. Regards, -- Nicolas Goaziou