emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Russell Adams <RLAdams@AdamsInfoServ.Com>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Status line change?
Date: Thu, 22 Jun 2017 21:16:42 -0400	[thread overview]
Message-ID: <87d19v7bb9.fsf@kyleam.com> (raw)
In-Reply-To: <20170623005342.GC16800@volibear.adamsinfoserv.com>

Russell Adams <RLAdams@AdamsInfoServ.Com> writes:

> On Thu, Jun 22, 2017 at 08:27:41PM -0400, Kyle Meyer wrote:

>> Testing with 9.0.5 and 9.0.9, I see a "TODO state changed to DONE"
>> message in the echo area, which I think is what you're referring to.
>> Not sure what the issue would be.  You could check if you see the
>> message in your *Messages* buffer.  If you do, then a subsequent message
>> is may be masking it.  You could also debug org-todo to verify that the
>> "(message "TODO state changed to %s" (org-trim next))" line is being
>> executed.
>
> I just tested it again, and the key is if the headline is on the screen I see a status message. If the headline is off
> screen there is no update on the status line. That's why it's an annoyance, I have to scroll back several screens to
> confirm it changes to DONE.

I see.  With the headline off the screen, I can reproduce this.  I've
bisected it down to dd17e9d29 (org.el (org-todo): When changing from one
state to the same state, throw a more accurate message, 2014-05-31).

That change seems to have unintentionally reversed the visibility check,
which should be

-- >8 --
diff --git a/lisp/org.el b/lisp/org.el
index 1e6d00973..d9b6489ff 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12681,7 +12681,7 @@ (defun org-todo (&optional arg)
 	    (replace-match next t t)
 	    (cond ((equal this org-state)
 		   (message "TODO state was already %s" (org-trim next)))
-		  ((pos-visible-in-window-p hl-pos)
+		  ((not (pos-visible-in-window-p hl-pos))
 		   (message "TODO state changed to %s" (org-trim next))))
 	    (unless head
 	      (setq head (org-get-todo-sequence-head org-state)

  reply	other threads:[~2017-06-23  1:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 23:39 Status line change? Russell Adams
2017-06-23  0:27 ` Kyle Meyer
2017-06-23  0:53   ` Russell Adams
2017-06-23  1:16     ` Kyle Meyer [this message]
2017-06-23  1:36       ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d19v7bb9.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=RLAdams@AdamsInfoServ.Com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).