From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: S5 HTML export - org9.1.1 Date: Sat, 07 Oct 2017 14:51:05 -0400 Message-ID: <87d15ypzae.fsf@kyleam.com> References: <87376v81pn.fsf@pclin.dcthindom.org> <87fuavoufs.fsf@kyleam.com> <87shev6jxw.fsf@pclin.dcthindom.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0uBt-0002jI-3u for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 14:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0uBp-0000MU-UQ for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 14:51:13 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:58835 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0uBp-0000Lz-NF for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 14:51:09 -0400 In-Reply-To: <87shev6jxw.fsf@pclin.dcthindom.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: dchechin92@gmail.com, emacs-orgmode@gnu.org Cc: emacs@rickster.com dchechin92@gmail.com writes: > I have evaluated the following function found in ox-html.el > and indeed the S5 html works when this function is defined. > > (defun org-html-end-plain-list (type) > "Insert the end of the HTML list depending on TYPE." > (case type > (`ordered "") > (`unordered "") > (`descriptive ""))) Yes, that's the function that was removed in 8855c23c6. > I don't know if this function should appear accordly in > ox-S5.el or elsewhere. As I don't use development environment > I don't know how a patch has to be submitted. > > Anyway thank for your help. Hope it can be useful for the > person who knows how to implement it and where. I don't use ox-s5.el, but the I think the below fix should do. I'll push it in a few days if no one objects. -- >8 -- Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list * contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of org-html-end-plain-list. The function org-html-end-plain-list was deleted in 8855c23c6 (ox-html: Plain list supports arbitrary attributes, 2017-02-13). Reported-by: --- contrib/lisp/ox-s5.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el index 8f9501058..0496aae19 100644 --- a/contrib/lisp/ox-s5.el +++ b/contrib/lisp/ox-s5.el @@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info) "<%s class='org-%s%s'>" tag tag (if (org-export-get-node-property :INCREMENTAL plain-list t) " incremental" "")) - contents (org-html-end-plain-list type)))) + contents + (format "" tag)))) (defun org-s5-inner-template (contents info) "Return body of document string after HTML conversion. -- 2.14.2