From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: utf-8 support for ob-dot.el [9.1.14 (9.1.14-1-g4931fc-elpa @ c:/Users/sig/emacs261/.emacs.d/elpa/org-9.1.14/)] Date: Thu, 27 Sep 2018 16:58:46 +0200 Message-ID: <87d0szhtqx.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5Xkk-0002oH-Kk for emacs-orgmode@gnu.org; Thu, 27 Sep 2018 10:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5Xkh-0004ch-Cu for emacs-orgmode@gnu.org; Thu, 27 Sep 2018 10:58:54 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35117) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5Xkh-0004bC-0S for emacs-orgmode@gnu.org; Thu, 27 Sep 2018 10:58:51 -0400 In-Reply-To: (Sigmund Tzeng's message of "Sat, 22 Sep 2018 14:10:02 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Sigmund Tzeng Cc: emacs-orgmode@gnu.org Hello, Sigmund Tzeng writes: > When trying to render a dot file with utf-8 encoded characters, > org babel complained about the encodings. I cross checked ob-go.el at > line 107-108 and made an identical patch to make utf-8 dot files work: > > vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv > diff --git "a/elpa\\org-9.1.14\\ob-dot.el" > "b/\\emacs261\\share\\emacs\\26.1\\lisp\\org\\ob-dot.el" > index 0fe50d4..31e0a4f 100644 > --- "a/elpa\\org-9.1.14\\ob-dot.el" > +++ "b/\\emacs261\\share\\emacs\\26.1\\lisp\\org\\ob-dot.el" > @@ -69,8 +69,6 @@ This function is called by `org-babel-execute-src-block'." > (cmdline (or (cdr (assq :cmdline params)) > (format "-T%s" (file-name-extension out-file)))) > (cmd (or (cdr (assq :cmd params)) "dot")) > - (coding-system-for-read 'utf-8) ;; use utf-8 with subprocesses > - (coding-system-for-write 'utf-8) > (in-file (org-babel-temp-file "dot-"))) > (with-temp-file in-file > (insert (org-babel-expand-body:dot body params))) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I'm a bit surprised Emacs doesn't do the right thing here. Anyway, could you provide a commit message and use "git format-patch" command. Also, could you add TINYCHANGE cookie if you haven't signed FSF papers yet. Thank you. Regards, -- Nicolas Goaziou