From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ihor Radchenko Subject: Re: Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)] Date: Mon, 19 Aug 2019 09:52:00 +0800 Message-ID: <87d0h12a7z.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> References: <87tvaydb4y.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39677) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzWrB-0006F9-Ax for emacs-orgmode@gnu.org; Sun, 18 Aug 2019 21:53:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzWrA-0001A5-1K for emacs-orgmode@gnu.org; Sun, 18 Aug 2019 21:53:13 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:46940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzWr9-00018y-Q2 for emacs-orgmode@gnu.org; Sun, 18 Aug 2019 21:53:11 -0400 Received: by mail-pf1-x42a.google.com with SMTP id q139so178016pfc.13 for ; Sun, 18 Aug 2019 18:53:11 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Carsten Dominik Cc: org-mode list Thanks! Carsten Dominik writes: > Hi Ihor, > > thank you for the report. > It would be too much work to *preserve* the visibility state of everything > in the sorting area, but you are right, the drawers at lease should be > closed. I fixed this, the fix is in master. > > Carsten > > On Sat, Aug 3, 2019 at 8:22 AM Ihor Radchenko wrote: > >> >> org-sort-entries seems to unfold everything in the subtree even if no >> modification was done to the buffer during sorting. >> >> Steps to reproduce: >> >> Consider the following org file: >> #+begin_src org >> ,* a >> :PROPERTIES: >> :ID: 279e797c-f4a7-47bb-80f6-e72ac6f3ec55 >> :END: >> :DRAWER: >> Blah >> :END: >> >> ,** test >> #+end_src >> >> 1. emacs -Q >> 2. Fold all the drawers and entries in the buffer >> 3a. Call M-x org-sort-entries p >> 3b. Call M-: (org-sort-entries nil ?p) RET >> >> >> Expected behaviour for 3a: Subtree is unfolded, all the property drawers >> are folded, buffer is unchanged >> Observed behaviour for 3a: Subtree is unfolded, all the property drawers >> are also unfolded, buffer is marked modified >> >> Expected behaviour for 3b: Subtree is folded, all the property drawers >> are folded, buffer is unchanged >> Observed behaviour for 3b: Subtree is unfolded, all the property drawers >> are also unfolded, buffer is marked modified >> >> Regards, >> Ihor >> >> >> >> >> Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit) >> of 2019-04-29 >> Package: Org mode version 9.1.13 (9.1.13-dist @ >> /home/yantar92/.emacs.d/straight/build/org/) >> -- >> Ihor Radchenko, >> PhD, >> Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) >> State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong >> University, Xi'an, China >> Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg >> >> >> -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg