From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: FW: [RFC] Link-type for attachments, more attach options Date: Sat, 18 Jan 2020 22:56:19 +0800 Message-ID: <87d0bgbyp8.fsf@gmail.com> References: <87o8v7eamw.fsf@gmail.com> <87sgkhkzpr.fsf@gmail.com> <87r1zzk5yr.fsf@gmail.com> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50341) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ispWY-0003PI-EW for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 09:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ispWW-0005MU-TL for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 09:56:30 -0500 Received: from [183.246.141.113] (port=10670 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ispWV-0005JF-Ih for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 09:56:28 -0500 In-reply-to: <87r1zzk5yr.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= Cc: "emacs-orgmode@gnu.org" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable stardiviner writes: I finally figured out why the link always failed. Because it use wrong vari= able which is old filename path. I attached a patch. > Gustav Wikstr=C3=B6m writes: > >> Hi, >> >>> -----Original Message----- >>> From: stardiviner >>> Sent: den 15 januari 2020 07:21 >>> To: Gustav Wikstr=C3=B6m >>> Cc: numbchild@gmail.com; emacs-orgmode@gnu.org >>> Subject: Re: [O] FW: [RFC] Link-type for attachments, more attach optio= ns >>>=20 >>> [...] >>>=20 >>> >> I found when I set option ~(setq org-attach-store-link-p t)~. Then >>> >> attach a file, store file link with =3D[C-c C-l]=3D. The stored link= . I >>> >> open this link got error "No such file: ....". I tested this with >>> >> minimal Emacs config. confirmed this problem. >>> >> >>> > >>> > I cannot reproduce this. In my try with a minimal Emacs (emacs -q) and >>> with only that single customization it works for me. I'm testing it in >>> linux. A wild guess.. Could it be that you used the move operation inst= ead >>> of the copy operation when attaching the file? >>> > >>> > Regards >>> > Gustav >>>=20 >>> Did you reproduce this issue with =3Demacs -q=3D ? That is a built-in O= rg Mode >>> version which does not contains the latest version =3Dorg-attach.el=3D. >>>=20 >>> Here is my minimal Emacs config: >>> >>> [...] >>> >>> ;;=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> =3D=3D=3D=3D=3D=3D >>> ;;; Here is org-attach.el customization >>>=20 >>> (require 'org-attach) >>>=20 >>> ;; store link auto with `org-store-link' using `file:' link type or >>> `attachment:' link type. >>> (setq org-attach-store-link-p 'attached) (setq org-attach-dir-relative = t) >>> (setq org-attach-preferred-new-method 'ask) #+end_src >>>=20 >>> #+begin_src sh :eval no >>> emacs -q -l '~/.config/emacs/minimal-init.el' >>> #+end_src >> > >> Hmm, in the first mail you said that you set org-attach-store-link-p to = t, but >> in your config it says 'attached. > > Sorry about this. > >> I've tried with a minimal config as well >> (using emacs -q because I build the newest org mode version into the ema= cs >> folder) and can only reproduce your issue when using the attached option= for >> org-attach-store-link-p and then inserting that link with C-c C-l /in an= other >> heading/. Pasting the link in another heading is expected to break since= the >> attachment link is context dependent (i.e. requires an attachment folder= ). >> Makes sense? If I'm still misunderstanding your use-case, would you care= to >> describe the steps to reproduce it more in detail? > > After updated commit, don't know why, but all links worked again. I'm not= good > at expressing thanks, but you got all my thanks on this. :) > >> Regards=09 >> Gustav >>=20=20 --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-org-attach-store-link-use-old-filename.patch >From 006583a83bc3b05b28ed1ad3610081066c0b1f95 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Sat, 18 Jan 2020 22:51:53 +0800 Subject: [PATCH] Fix org-attach store link use old filename --- lisp/org-attach.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/org-attach.el b/lisp/org-attach.el index 6bb438c72..c3d3ecda9 100644 --- a/lisp/org-attach.el +++ b/lisp/org-attach.el @@ -504,8 +504,8 @@ METHOD may be `cp', `mv', `ln', `lns' or `url' default taken from (file-name-nondirectory fname)) org-stored-links)) ((eq org-attach-store-link-p t) - (push (list (concat "file:" file) - (file-name-nondirectory file)) + (push (list (concat "file:" fname) + (file-name-nondirectory fname)) org-stored-links))) (if visit-dir (dired attach-dir) -- 2.25.0 --=-=-=--