emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix verbatim block fontification to end blocks on headlines
Date: Wed, 12 Feb 2020 09:38:31 +0100	[thread overview]
Message-ID: <87d0aknqt4.fsf@gnu.org> (raw)
In-Reply-To: <CA+G3_PMZLH3r-gaABTszwbe2AMenDXpwSFB57nD8cy68BCC+uw@mail.gmail.com> (Tom Gillespie's message of "Fri, 13 Dec 2019 15:25:17 -0800")

Hi Tom,

Tom Gillespie <tgbugs@gmail.com> writes:

> An unrelated question.
>
> I've written some basic tests for this and I couldn't find any other
> tests that seemed to deal with fontification at all. In order to get
> fontification tests to work I added a call to `font-lock-ensure' inside
> `org-test-with-temp-text' (see excerpted patch bit below). Given how
> frequently `org-test-with-temp-text' is used, does it make sense to
> create a separate version of that macro just for testing with
> fontification? I have no idea what the performance impact would be, so
> any guidance is appreciated.

I tested this patch for a week or so, running tests not as often as I
should (obviously), but I noticed to performance issue.  I applied it
in master.

Thanks!

-- 
 Bastien

  parent reply	other threads:[~2020-02-12  8:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 23:25 [PATCH] Fix verbatim block fontification to end blocks on headlines Tom Gillespie
2019-12-14 14:45 ` Nicolas Goaziou
2020-02-12  8:38 ` Bastien [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-12  3:35 Tom Gillespie
2019-12-12  8:40 ` Nicolas Goaziou
2019-12-12 10:27   ` Tom Gillespie
2019-12-12 12:20     ` Adam Porter
2019-12-18  4:38     ` Tom Gillespie
2019-12-19 13:09       ` Nicolas Goaziou
2019-12-26 18:47       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0aknqt4.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tgbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).