From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface Date: Tue, 18 Feb 2020 14:15:22 +0100 Message-ID: <87d0acujdh.fsf@gnu.org> References: <20180422205003.87836-1-roberthambrock@gmail.com> <20180422205003.87836-3-roberthambrock@gmail.com> <87v9ocuesg.fsf@gmail.com> <87imkb7mwj.fsf@gnu.org> <87y2t6fqwj.fsf@gmail.com> <87pnei8oe0.fsf@bzg.fr> <87k14prbb5.fsf@gmail.com> <87eeuxqyeq.fsf@bzg.fr> <87eeuxqjxq.fsf@gmail.com> <87v9o8zyzs.fsf@gnu.org> <874kvojbh4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45117) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j42il-0000bP-9n for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 08:15:28 -0500 In-Reply-To: <874kvojbh4.fsf@gmail.com> (stardiviner's message of "Tue, 18 Feb 2020 21:01:27 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: roberthambrock@gmail.com, emacs-orgmode@gnu.org Hi stardiviner, stardiviner writes: > I tested your method, true. And I also pulled that latest ob-clojure.el changes. > Works great, I like this new method more. Thanks for your > improvement. Thanks for your feedback. Also, you may have noted that the code for Clojure sessions has been removed - I could not make it work, even in previous versions. If you know sesman/cider better than I do and can propose to handle sesman/cider sessions correctly, please go ahead. By "correctly" I mean requesting the launch of a (sibling?) nREPL process buffer when :session is set to a string. > The clojurescript support has a ~:target~ header argument to tell CIDER this is a > clojurescript code, I don't know CIDER internal much, but CIDER eval should eval > in a ClojureScript corresponding REPL. Yes, what I meant was that for now ":target cljs" won't let you start a nREPL unless you are in a ClojureScript project. cider-jack-in-cljs will ask for the cljs method (figwheel-main, etc.) but if your org file is in, e.g., an empty directory, there is no such cljs configuration file. -- Bastien