Bug: org-agenda-finalize throws args-out-of-range [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/nivekuil/.emacs.d/elpa/org-plus-contrib-20200302/)]

Bug: org-agenda-finalize throws args-out-of-range [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/nivekuil/.emacs.d/elpa/org-plus-contrib-20200302/)]

[Kevin Liu]

This bit in org-agenda-finalize:

(save-excursion
	  (while (org-activate-links (point-max))
	    (add-text-properties (match-beginning 0) (match-end 0)
				 '(face org-link))))

Will throw an error at add-text-properties:

Debugger entered--Lisp error: (args-out-of-range 0 2)
  add-text-properties(0 2 (face org-link))
  org-agenda-finalize()
  org-agenda-list(nil)
  funcall-interactively(org-agenda-list nil)
  call-interactively(org-agenda-list)
  org-agenda(nil)
  funcall-interactively(org-agenda nil)
  call-interactively(org-agenda nil nil)
  command-execute(org-agenda)

This happens after I open the agenda, C-c C-o a captured file from my
org-journal, and then open the agenda again.  The effect is that
subsequent links after the first are not styled (visible brackets, not a
link).

However, it seems like add-text-properties may be redundant, and
org-activate-links does it already?  I deleted the add-text-properties
sexp entirely and it seems to work as expected.

Emacs  : GNU Emacs 27.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.14, cairo version 1.17.3)
 of 2020-02-24
Package: Org mode version 9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/nivekuil/.emacs.d/elpa/org-plus-contrib-20200302/)

Re: Bug: org-agenda-finalize throws args-out-of-range [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/nivekuil/.emacs.d/elpa/org-plus-contrib-20200302/)]

[Bastien]

Hi Kevin,

Kevin Liu <kevin@nivekuil.com> writes:

> This bit in org-agenda-finalize:
>
> (save-excursion
> 	  (while (org-activate-links (point-max))
> 	    (add-text-properties (match-beginning 0) (match-end 0)
> 				 '(face org-link))))
>
> Will throw an error at add-text-properties:
>
> Debugger entered--Lisp error: (args-out-of-range 0 2)
>   add-text-properties(0 2 (face org-link))
>   org-agenda-finalize()
>   org-agenda-list(nil)
>   funcall-interactively(org-agenda-list nil)
>   call-interactively(org-agenda-list)
>   org-agenda(nil)
>   funcall-interactively(org-agenda nil)
>   call-interactively(org-agenda nil nil)
>   command-execute(org-agenda)

FWIW I could not reproduce this bug but the code was wrong indeed, I
removed the redundant call to `add-text-properties' in maint.

I hope it fixed the problem you had, thanks for reporting it.

Best,

-- 
 Bastien