From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oCYbKAlg0l7MHwAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 13:30:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iPnSIwlg0l5STAAAbx9fmQ (envelope-from ) for ; Sat, 30 May 2020 13:30:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32368940308 for ; Sat, 30 May 2020 13:30:49 +0000 (UTC) Received: from localhost ([::1]:50038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf1ZY-00035L-3v for larch@yhetil.org; Sat, 30 May 2020 09:30:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf1Yg-00035D-Pp for emacs-orgmode@gnu.org; Sat, 30 May 2020 09:29:54 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jf1Yf-0007kY-VP for emacs-orgmode@gnu.org; Sat, 30 May 2020 09:29:54 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1590845390; cv=none; d=zohomail.com; s=zohoarc; b=lwtpQD9znUG1BHrvdZei1yJeql03iJDy8kzRwlJcdYLwi11Sl3tUEfRWyuwdVCF8isisSctoOW9C6oOMIlSRJMjOcqH/C8Xwr08PU8Yfz34KspFfXJ91LW9huc5Od1DJNJ6FvBe3TU+9zOURGxsNBeiQTjkdHS8quKa66GLS3vc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590845390; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=J66D3M7DGepuVwfxJpNAA0X4qceyOahdGzSGM52qoRM=; b=SmsmYd/TMIT0aYA666SXpH75tI64ARJwk+Yuj//PSpkXgTSTPvqTPwPeR1fGoNLnLGjnFQ3R9vk0L0iBg3rcE4cp+OHpZ42GR67GvTp9vtCFoIfoWSZaibFH0Mus00/NC0y8wTrW2yu9B70fCOn8aTQQxtmtUSKrQQnv3Ip2nw8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=nivekuil.com; spf=pass smtp.mailfrom=kevin@nivekuil.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1590845390; s=mail; d=nivekuil.com; i=kevin@nivekuil.com; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=J66D3M7DGepuVwfxJpNAA0X4qceyOahdGzSGM52qoRM=; b=UZyRxq3nxNPQ72gulql+QSpfdWzt8ws8MCVsR3czhqy9k5X/meiQVMUcvFXGIBnL gMiKYAMVYmeycuf79VGCwOUXMzAmUFhfWDN+FhY/nDTJNqxKYwGInchzUWwVjrKeW5a XJp57heu2Xr0oRMHB8Fduj9V/gMLs6RioXskxY0E= Received: from machina (71.212.158.154 [71.212.158.154]) by mx.zohomail.com with SMTPS id 1590845388613623.6639689081289; Sat, 30 May 2020 06:29:48 -0700 (PDT) User-agent: mu4e 1.5.1; emacs 27.0.91 From: Kevin Liu To: emacs-orgmode@gnu.org Subject: [PATCH] Fix org-narrow-to-subtree smaller than subtree Date: Sat, 30 May 2020 06:29:47 -0700 Message-ID: <87d06lpn3o.fsf@nivekuil.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-ZohoMailClient: External X-Zoho-Virus-Status: 1 Received-SPF: none client-ip=136.143.188.51; envelope-from=kevin@nivekuil.com; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/30 09:29:52 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, T_DKIM_INVALID=0.01, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none (invalid DKIM record) header.d=nivekuil.com header.s=mail header.b=UZyRxq3n; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: roo5pDJsAaVv --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I noticed that when I narrow to a subtree and then hit org-mark-element, I can=E2=80=99t kill the text because the narrow is actually 1 char smaller. This seemed like an unpleasant workaround, and I think the behavior can be changed without any real negative consequences. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Narrow-to-whole-subtree-instead-of-1-char-less.patch >From 61260469a9ad37ad4011cc489dc4372b02491b4d Mon Sep 17 00:00:00 2001 From: nivekuil Date: Tue, 26 May 2020 23:17:43 -0700 Subject: [PATCH] Narrow to whole subtree instead of 1 char less --- lisp/org.el | 1 - testing/lisp/test-org-datetree.el | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 0808fc210..e9771512d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -7749,7 +7749,6 @@ If yes, remember the marker and the distance to BEG." (narrow-to-region (progn (org-back-to-heading t) (point)) (progn (org-end-of-subtree t t) - (when (and (org-at-heading-p) (not (eobp))) (backward-char 1)) (point))))))) (defun org-toggle-narrow-to-subtree () diff --git a/testing/lisp/test-org-datetree.el b/testing/lisp/test-org-datetree.el index 5557d5e23..f7247766a 100644 --- a/testing/lisp/test-org-datetree.el +++ b/testing/lisp/test-org-datetree.el @@ -58,7 +58,7 @@ ;; Sort new entry in right place. (should (string-match - "\\`\\* 2012\n\\*\\* 2012-02 .*\n\\*\\*\\* 2012-02-01 .*\n\n\\*\\* 2012-03 .*\n\\*\\*\\* 2012-03-29 .*\\'" + "\\`\\* 2012\n\\*\\* 2012-02 .*\n\\*\\*\\* 2012-02-01 .*\n\\*\\* 2012-03 .*\n\\*\\*\\* 2012-03-29 .*\\'" (org-test-with-temp-text "* 2012\n** 2012-03 month\n*** 2012-03-29 day" (let ((org-datetree-add-timestamp nil)) (org-datetree-find-date-create '(3 29 2012)) @@ -161,7 +161,7 @@ ;; Sort new entry in right place. (should (string-match - "\\`\\* 2015\n\\*\\* 2015-W01\n\\*\\*\\* 2014-12-31 .*\n\n\\*\\* 2015-W36\n\\*\\*\\* 2015-09-01 .*\\'" + "\\`\\* 2015\n\\*\\* 2015-W01\n\\*\\*\\* 2014-12-31 .*\n\\*\\* 2015-W36\n\\*\\*\\* 2015-09-01 .*\\'" (org-test-with-temp-text "* 2015" (let ((org-datetree-add-timestamp nil)) (org-datetree-find-iso-week-create '(9 1 2015)) -- 2.26.2 --=-=-=--