emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Roman Rudakov <rrudakov@pm.me>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Tue, 29 Sep 2020 08:00:57 +0000	[thread overview]
Message-ID: <87d025ypu1.fsf@pm.me> (raw)
In-Reply-To: <87o8m6aysz.fsf@protesilaos.com>

"Protesilaos Stavrou" <info@protesilaos.com> writes:

> Roman Rudakov <rrudakov@pm.me> [2020-09-15, 18:50 +0000]:
>> I use theme which draw boxes around priority cookie. Before updating to
>> version 9.4 box was rendered just around square brackets, but since
>> version 9.4 it has additional space at the end.
>> I think it's related to the fact that org-priority face definition used
>> to use separate regex which didn't include space, and now it uses
>> variable org-priority-regexp which does include additional space
>> character.
>> [...]
> This issue is noticeable with any face properties for 'org-priority'
> such as box, background, underline, overline.
> Just to add a reproducible recipe for this case.
> On 'emacs -Q' running Org 9.4:
> + C-x C-f /tmp/test.org
> + Insert a heading, like:
>     * TODO [#A] This is a test
> …see attached screenshot with "default" state.
> * Now evaluate the following expression:
>     (set-face-attribute 'org-priority nil :underline t)
> …see attached screenshot with "edited" state.
> --
> Protesilaos Stavrou
> protesilaos.com


I think proper value for `org-priority-regex` should be
".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of
the brackets, It won't break anything and face definition will be

Best regards.

  reply	other threads:[~2020-09-29  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 18:50 Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)] Roman Rudakov
2020-09-16  8:52 ` Protesilaos Stavrou
2020-09-29  8:00   ` Roman Rudakov [this message]
2020-10-04 14:36     ` Protesilaos Stavrou
2020-10-11  6:40       ` Kyle Meyer
2020-10-12  6:48         ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d025ypu1.fsf@pm.me \
    --to=rrudakov@pm.me \
    --cc=emacs-orgmode@gnu.org \
    --cc=info@protesilaos.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).