From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eA+jEWDOj1+KfAAA0tVLHw (envelope-from ) for ; Wed, 21 Oct 2020 06:00:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2GhrDWDOj185TAAAB5/wlQ (envelope-from ) for ; Wed, 21 Oct 2020 06:00:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F09A940418 for ; Wed, 21 Oct 2020 05:59:59 +0000 (UTC) Received: from localhost ([::1]:48858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kV7AD-0000HT-1j for larch@yhetil.org; Wed, 21 Oct 2020 01:59:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kV79p-0000HC-Cp for emacs-orgmode@gnu.org; Wed, 21 Oct 2020 01:59:33 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:34773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kV79n-0003C5-8y for emacs-orgmode@gnu.org; Wed, 21 Oct 2020 01:59:33 -0400 Received: by mail-wr1-x443.google.com with SMTP id i1so1561987wro.1 for ; Tue, 20 Oct 2020 22:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=8EG4sftXtbIDD02rUrnxCWvC9g73Edgp78JcY42otV8=; b=kymXnP9UFwYF1xo5oQkQE3uFjP8H6pybv9Bc6aJxmGdb/rF+r/mQNo+x5u4OHfOAw0 GaEXaf/NVG7q6oxwaXItT1zX52hWa/z9FR/AljYaDJwl5s6orKV1Y1aOTfAoJ31Jq+2K xYcXPapeWm8nCL6EJxgesEBDLXoKf4DzqIpFWXUydB+fZRVeqaW38ua1YJGr2A2O9KoO ZmzlqruB/BaIviR/UpiX2xaMf2Oae1NNpnbJmAcFjtuFBAtPusn1oRedYogZz9fsN3Wo 9MB4XySUJrS0El9KP3VTsBCnDyOh0DESHj2PDWDXQXlvFhEHrXKYC8XYIutZwHqVgqCE wfBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=8EG4sftXtbIDD02rUrnxCWvC9g73Edgp78JcY42otV8=; b=Ys0GaMqs1enFAmOtXs5mj64OASjtiiLELUE9d6/X7aABTCLdeG83wb8pwtywSfX+XB /dfUoxdCv7RiqpWchQdhsrbK8MiI9aRgVbKj4mFHUX97tWZZQ/45sN6SAgy35Cs45hXq i9wFJKxkb7WIZ8l2z9kiSsSi4E4qHIglkqWripKd4yymQWEthiYgiphVIK0xXmY5RFL7 WzFZsqrtCJKWk3rR3WR9kfIoNW9URz3i3yLwCotaS4Ss82lnCxgytB0gUGS+RA8c4LxL NHpPkqEu+zi9rLF1vARFuAERWim6QcpldxCi8Cwudo7SkRsxl0+Lhv/LU7WxM4LrcK0h Hq5g== X-Gm-Message-State: AOAM531Drs34PclTYAA+RESRI5e+B7joHRhAANXSKDrgDWYN+Qfrwl5P oS29dbE1JoONYE5ZJmfvMRPeyiu/L0c= X-Google-Smtp-Source: ABdhPJwG08FP1nVr8cX6sP9PFerFH84P83fKe71XqIwGmbdbBqEKMbkgajsJ/feqhSObqeNvpITdsw== X-Received: by 2002:a5d:4608:: with SMTP id t8mr2392683wrq.231.1603259969193; Tue, 20 Oct 2020 22:59:29 -0700 (PDT) Received: from fnox (h-160-111.A147.priv.bahnhof.se. [85.24.160.111]) by smtp.gmail.com with ESMTPSA id c18sm1798240wrt.10.2020.10.20.22.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 22:59:28 -0700 (PDT) References: <87h7qohfm8.fsf@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: John Herrlin To: ian martins Subject: Re: [PATCH] ob-java In-reply-to: Message-ID: <87d01cglvm.fsf@gmail.com> Date: Wed, 21 Oct 2020 07:59:26 +0200 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=jherrlin@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=kymXnP9U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: BOHyX5oDR7pW I did and it looks really good. The difference in this example: #+BEGIN_SRC java import rx.Observable; Observable.range(5, 3) .subscribe((Integer i) -> { System.out.println("Got: " + i); }, (Throwable t) -> { t.printStackTrace();}, () -> { System.out.println("Ending stream"); }); #+END_SRC from the ones I posted yesterday is tremendous! I am not very experienced with Emacs lisp but I think it's pretty easy to understand how things works and follow the code. The comments are also of good help. I really appreciate the work you have done! What do you think about having a configurable list where the user can add =org-babel-java--import-maybe=? In my current use case I could then add RxJava imports to that list and the imports could be removed from the source code block. NIT Some spacing when writing =public static...= #+BEGIN_SRC diff diff --git a/lisp/ob-java.el b/lisp/ob-java.el index 94c3f69cf..4f3904871 100644 --- a/lisp/ob-java.el +++ b/lisp/ob-java.el @@ -220,7 +220,7 @@ RESULT-FILE is the temp file to write the result." (org-babel-java--move-past org-babel-java--class-re) (insert "\n public static void main(String[] args) { System.out.print(\"success\"); -}\n\n")) + }\n\n")) ;; special handling to return value (when (eq result-type 'value) #+END_SRC ian martins writes: > Thanks for testing, and thanks for pointing that out. I will fix it so that > `public` is optional. > > btw, in your example you didn't have to specify `:classname` since you > defined the class name in the source block. > > btw2, did you notice that you can C-c C-c on source blocks that don't have > main methods and it'll compile without error? > > On Tue, Oct 20, 2020 at 3:17 PM John Herrlin wrote: > >> >> Hey, >> >> Did some debugging and found out that my class didn't contained =public= >> and the patch requires it to be. >> >> This works fine: >> >> #+HEADER: :classname Main >> #+HEADER: :dir src >> #+HEADER: :cmdline -classpath ./rxjava-1.3.8.jar:. >> #+HEADER: :cmpflag -classpath ./rxjava-1.3.8.jar >> #+BEGIN_SRC java :results output code >> import rx.Observable; >> public class Main { >> public static void main(String[] args) { >> Observable.range(5, 5) >> .subscribe(System.out::println); >> } >> } >> #+END_SRC >> >> >> >> >> ian martins writes: >> >> > I noticed that the tests didn't run with "make test." This updates the >> > patch so that they can. I didn't add java to the list of default >> languages >> > because the java tests are slow. >> > >> > On Mon, Oct 5, 2020 at 9:23 AM ian martins wrote: >> > >> >> I wrote those examples in an org file so I could test as I wrote them, >> and >> >> then exported it to make it more readable, but the export resulted in >> >> source block headers being lost. Here is the same without export: >> >> ---- >> >> * Changes >> >> >> >> - support for functional mode (~:results value~) >> >> - accept variables >> >> - don't require package, class, and main definitions >> >> - write source and result tempfiles to ~org-babel-temporary-directory~, >> >> but respects the ~:dir~ header >> >> - work with tramp >> >> >> >> * Examples >> >> ** Example 1 >> >> This outputs "hello." If class and main definitions aren't given the >> >> code block will be wrapped in generic ones. >> >> >> >> #+begin_src java :results output silent >> >> System.out.print("hello"); >> >> #+end_src >> >> >> >> This is exactly equivalent: >> >> >> >> #+begin_src java :results output silent >> >> public class Main { >> >> public static void main(String[] args) { >> >> System.out.print("hello"); >> >> } >> >> } >> >> #+end_src >> >> >> >> ** Example 2 >> >> This also outputs "hello." >> >> >> >> #+begin_src java :results value silent >> >> return "hello"; >> >> #+end_src >> >> >> >> ** Example 3 >> >> This generates the class "Example" in the package "org.orgmode" in the >> >> current directory. >> >> >> >> #+begin_src java :results output silent :classname org.orgmode.Example >> >> :dir . >> >> System.out.print("hello, org-mode"); >> >> #+end_src >> >> >> >> ** Example 4 >> >> The "Hey" class defines a static method but no main. C-c C-c on the >> >> "Hey" source block will write "./org/orgmode/Hey.java" and compile it. >> >> >> >> The "Main" class calls the "Hey" class. C-c C-c on the "Main" source >> >> block will write "./org/orgmode/Main.java" and compile and run it. >> >> >> >> #+begin_src java :results output silent :dir . >> >> package org.orgmode; >> >> >> >> public class Hey { >> >> public static String say() { >> >> return "hey"; >> >> } >> >> } >> >> #+end_src >> >> >> >> #+begin_src java :results output silent :dir . >> >> package org.orgmode; >> >> >> >> public class Main { >> >> public static void main(String[] args) { >> >> System.out.print(Hey.say()); >> >> } >> >> } >> >> #+end_src >> >> >> >> Instead of C-c C-c, we could have added tangle headers and written the >> >> source files out by tangling. >> >> >> >> ** Example 5 >> >> This prints the variable from the header >> >> >> >> #+begin_src java :var msg="hello, org-mode" :results output silent >> >> System.out.print(msg); >> >> #+end_src >> >> >> >> ** Example 6 >> >> This prints "hello, org-mode." The table is provided to the method as a >> >> list of lists. >> >> >> >> #+name: table >> >> | message | hello, org-mode | >> >> >> >> #+begin_src java :var tbl=table :results output silent >> >> System.out.print(tbl.get(0).get(1)); >> >> #+end_src >> >> >> >> ** Example 7 >> >> This example returns a list. >> >> >> >> Note that you're allowed to specify imports without defining the class >> >> or main methods. >> >> >> >> #+begin_src java :results value :exports both >> >> import java.util.Arrays; >> >> >> >> return Arrays.asList("message", "hello, org-mode"); >> >> #+end_src >> >> >> >> #+RESULTS: >> >> | message | hello, org-mode | >> >> >> >> On Mon, Oct 5, 2020 at 8:35 AM ian martins wrote: >> >> >> >>> 1 Changes >> >>> ========= >> >>> >> >>> - support for functional mode (`:results value') >> >>> - accept variables >> >>> - don't require package, class, and main definitions >> >>> - write source and result tempfiles to >> >>> `org-babel-temporary-directory', but respects the `:dir' header >> >>> - work with tramp >> >>> >> >>> >> >>> 2 Examples >> >>> ========== >> >>> Some examples follow. See the tests for more examples. I'll write >> >>> proper docs after review. >> >>> >> >>> 2.1 Example 1 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This outputs "hello." If class and main definitions aren't given the >> >>> code block will be wrapped in generic ones. >> >>> >> >>> ,---- >> >>> | System.out.print("hello"); >> >>> `---- >> >>> >> >>> This is exactly equivalent: >> >>> >> >>> ,---- >> >>> | public class Main { >> >>> | public static void main(String[] args) { >> >>> | System.out.print("hello"); >> >>> | } >> >>> | } >> >>> `---- >> >>> >> >>> >> >>> 2.2 Example 2 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This also outputs "hello." >> >>> >> >>> ,---- >> >>> | return "hello"; >> >>> `---- >> >>> >> >>> >> >>> 2.3 Example 3 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This generates the class "Example" in the package "org.orgmode" in >> the >> >>> current directory. >> >>> >> >>> ,---- >> >>> | System.out.print("hello, org-mode"); >> >>> `---- >> >>> >> >>> >> >>> 2.4 Example 4 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> The "Hey" class defines a static method but no main. C-c C-c on the >> >>> "Hey" source block will write "./org/orgmode/Hey.java" and compile >> it. >> >>> >> >>> The "Main" class calls the "Hey" class. C-c C-c on the "Main" source >> >>> block will write "./org/orgmode/Main.java" and compile and run it. >> >>> >> >>> ,---- >> >>> | package org.orgmode; >> >>> | >> >>> | public class Hey { >> >>> | public static String say() { >> >>> | return "hey"; >> >>> | } >> >>> | } >> >>> `---- >> >>> >> >>> ,---- >> >>> | package org.orgmode; >> >>> | >> >>> | public class Main { >> >>> | public static void main(String[] args) { >> >>> | System.out.print(Hey.say()); >> >>> | } >> >>> | } >> >>> `---- >> >>> >> >>> Instead of C-c C-c, we could have added tangle headers and written >> the >> >>> source files out by tangling. >> >>> >> >>> >> >>> 2.5 Example 5 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This prints the variable from the header >> >>> >> >>> ,---- >> >>> | System.out.print(msg); >> >>> `---- >> >>> >> >>> >> >>> 2.6 Example 6 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This prints "hello, org-mode." The table is provided to the method as >> >>> a list of lists. >> >>> >> >>> message hello, org-mode >> >>> >> >>> ,---- >> >>> | System.out.print(tbl.get(0).get(1)); >> >>> `---- >> >>> >> >>> >> >>> 2.7 Example 7 >> >>> ~~~~~~~~~~~~~ >> >>> >> >>> This example returns a list. >> >>> >> >>> Note that you're allowed to specify imports without defining the >> class >> >>> or main methods. >> >>> >> >>> ,---- >> >>> | import java.util.Arrays; >> >>> | >> >>> | return Arrays.asList("message", "hello, org-mode"); >> >>> `---- >> >>> >> >>> message hello, org-mode >> >>> >> >> >>