From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OK/aBqju4l/nMAAA0tVLHw (envelope-from ) for ; Wed, 23 Dec 2020 07:15:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gMWZAqju4l8BDwAAbx9fmQ (envelope-from ) for ; Wed, 23 Dec 2020 07:15:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91B009403C9 for ; Wed, 23 Dec 2020 07:15:51 +0000 (UTC) Received: from localhost ([::1]:48246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kryNC-0002FW-9w for larch@yhetil.org; Wed, 23 Dec 2020 02:15:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kryM6-0002Ej-8l for emacs-orgmode@gnu.org; Wed, 23 Dec 2020 02:14:43 -0500 Received: from out1.migadu.com ([91.121.223.63]:62440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kryM0-000751-6N; Wed, 23 Dec 2020 02:14:41 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1608707671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C1hYQaEn/G4g442MHZOX1mHhw5P2YZ1yDsSDakbfQYA=; b=SoOBFsrBKS3pJRYkRfJ/cRwW6PaQx0LRZ2NJgA15BYen7B2uh7VtsBpiLXH7RPlBvdd/uH Fphz7vA7sFxkxaqZGFgFpuiRPFctvxWvn406zZSDKLgJLC+KMs9COr77itl/sB+bfjBLiC SsECAoGkp1AOh39+rcgE+JI83+mad7CO6atZqrgxskAtIGm4/GHvECwltJ8bSdQo+Mcg1e AFG3zqGKg3mYwYFhptsxMaQaCMCk+gRKZ17VFk9463YaydJp8bsgCWRXU/aQ4Q4AFlDfE8 tOtZzz4FfO5sFbzdHLf8vfBjDrlTdg068UerDK86lio5NNDDuHyFFg2AM+Ow1g== From: Kyle Meyer To: TEC Subject: Re: [PATCH] org-plot abstractions and extension In-Reply-To: <87y2hpt568.fsf@gmail.com> References: <87imcrfntf.fsf@gmail.com> <87blijmnv9.fsf@gnu.org> <87lfhbhfhe.fsf@gmail.com> <87r1qp3fu1.fsf@gmail.com> <871rhxd2ib.fsf@gmail.com> <87r1pnoo5y.fsf@bzg.fr> <87lffv8oy5.fsf@gmail.com> <87zh2hosex.fsf@bzg.fr> <87im8tglbl.fsf@kyleam.com> <87zh25t8cj.fsf@gmail.com> <87y2hpt568.fsf@gmail.com> Message-ID: <87czz1gfje.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Wed, 23 Dec 2020 07:14:31 GMT Received-SPF: pass client-ip=91.121.223.63; envelope-from=kyle@kyleam.com; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=kyleam.com header.s=key1 header.b=SoOBFsrB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 91B009403C9 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: +/eUBzFE3N2h > Subject: [PATCH] org-plot.el: fix compiler warnings > > * (org--plot/values-stats): Replace `log10' with `log'. > (org--plot/nice-frequency-pick): Replace obsolete `case' with `pcase`. case is still available under the cl- prefix. If you wanted to use it in 73c99bf42 (org-plot.el: add utility functions for range,ticks), I don't see a reason not to use it now. > (org--plot/radar): Replace `s-join' with `mapconcat', removing the > implicit dependency on s.el. > (org-plot/gnuplot-script): Remove unused let bindings. > (org-plot/gnuplot-script): Replace free variable refence with expression s/refence/reference/ > @@ -210,9 +210,9 @@ values, namely regarding the range." > "From a the values in a TABLE of data, attempt to guess an appropriate number of ticks." > (let* ((row-data > (mapcar (lambda (row) (org--plot/values-stats > - (mapcar #'string-to-number (cdr row)) > - hard-min > - hard-max)) table)) > + (mapcar #'string-to-number (cdr row)) > + hard-min > + hard-max)) table)) Please drop this unrelated space change. > @@ -473,34 +473,36 @@ EOD > > (defun org--plot/radar (table params) > (let* ((data > - (concat "\"" (s-join "\" \"" (plist-get params :labels)) "\"" > + (concat "\"" (mapconcat #'identity (plist-get params :labels) "\" \"") "\"" > "\n" > - (s-join "\n" > - (mapcar (lambda (row) > - (format > - "\"%s\" %s" > - (car row) > - (s-join " " (cdr row)))) > - (append table (list (car table))))))) > + (mapconcat #'identity > + (mapcar (lambda (row) > + (format > + "\"%s\" %s" > + (car row) > + (mapconcat #'identity (cdr row) " "))) > + (append table (list (car table)))) > + "\n"))) The mapcar is unnecessary; you can reposition (lambda ...) as mapconcat's FUNCTION argument. Same comment applies to a spot farther down in the patch. Thanks.