From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MNO+OCvG5V8TNAAA0tVLHw (envelope-from ) for ; Fri, 25 Dec 2020 10:59:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sHSINCvG5V9IIwAA1q6Kng (envelope-from ) for ; Fri, 25 Dec 2020 10:59:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90683940274 for ; Fri, 25 Dec 2020 10:59:55 +0000 (UTC) Received: from localhost ([::1]:43974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kskp8-0007iZ-3v for larch@yhetil.org; Fri, 25 Dec 2020 05:59:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kskoN-0007iR-Eu for emacs-orgmode@gnu.org; Fri, 25 Dec 2020 05:59:07 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kskoL-0001Zp-Uk for emacs-orgmode@gnu.org; Fri, 25 Dec 2020 05:59:07 -0500 Received: by mail-wm1-x331.google.com with SMTP id y23so3509216wmi.1 for ; Fri, 25 Dec 2020 02:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GBfTXd45e+UzKfUKNXwk28Gh/sqR4wk3v+zQrctajIM=; b=otTEBeRAZ79TmlwUyRj2qF+XqQqnVqGYi0J9qk0/cowYu1H4jwLcL4uPp6U1eDY5H8 FGzVTAN6mHiDqhjsk9XFBNqcIHe9Ll6dPRdKsyfa6yOlP1HJzoBPSucj9tCwPzpdZbjF HoP+YsnE++RaJrtsHF/Di+nH+IikkYY11lKbJx3yg+ipoLYna92jcokz0XSwauDsCHPl qd1NxfUI5EnSsO35nHSNu7dszlAhPiQbZEVkI+XJPUs3+haw5eWYwd7U6X2GW+R/rAYR p2Dgq5OU7RKUb2psINOvP7MG4NZyVEf2FJQYMTmw0aSrGbGBU54eJwSC7/9V0VgBPMjc OIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GBfTXd45e+UzKfUKNXwk28Gh/sqR4wk3v+zQrctajIM=; b=JbeusRGCWRC0NyKiOX4wt3BZkKobtvMOzLpEWccYAMhvZzLbV0DnCze+9Wz+beHwYF 98gvWQzxgS6a/CAN8sR+OJYdzUWm5F/N95wk/fx3IZ2OFJm3iCDW/XATnxhOc0T2Adxa p60qfQo1zUCM24xWeNxRAIERDnyeEP1nhSfHpZdsblnqkHceEddeiMi5PN+Sj8Xfh3dK r4ieLf7iGZM50m2/HDSxOdMTII+qqFhxB015C9dzzGZ/uNIVX7Q6TVpL2xHNcvS8EtnL Nv52MgU6Ig7IFKhw/dnVusYWY8WcZoJDxYItDF7xk8GSLrPDZ2XLvmpNIIaJQxCUaz/f ofxg== X-Gm-Message-State: AOAM530e2WGMCnsdf/Q3rsHZQNmKWP+MHv/wPs5QRFqKeqoU7mxzBLgm C0ZBtHTW0KI0SYXBa094cCGkyCoymsE= X-Google-Smtp-Source: ABdhPJybOikDTcc0PvBuJ6ky5jw27c1JzPKy6mG5OR6rTJVCOuBjpXyLJo0ZBCF3UG7OLIPm+Csbzw== X-Received: by 2002:a1c:7d88:: with SMTP id y130mr7974377wmc.158.1608893943533; Fri, 25 Dec 2020 02:59:03 -0800 (PST) Received: from hirondell (alyon-654-1-449-182.w109-213.abo.wanadoo.fr. [109.213.105.182]) by smtp.gmail.com with ESMTPSA id w17sm7387278wmk.12.2020.12.25.02.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Dec 2020 02:59:02 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Ihor Radchenko Subject: Re: [9.4] Fixing logbook visibility during isearch References: <87h7x9e5jo.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com> <87sgbaw58y.fsf@localhost> <87pn6ew2pv.fsf@localhost> <8736393tlw.fsf@gmail.com> <87eemtm1ic.fsf@localhost> <875z83hwuc.fsf@gmail.com> <874knm61p3.fsf@localhost> <87r1nrdl5o.fsf_-_@gmail.com> <87r1nqjv9w.fsf@localhost> <87czz91v9h.fsf@gmail.com> <87v9d15dd5.fsf@localhost> <87blesa3mg.fsf@gmail.com> <875z4zam2s.fsf@localhost> <8735zu7p2u.fsf@gmail.com> <87bleizjh6.fsf@localhost> Date: Fri, 25 Dec 2020 11:59:01 +0100 In-Reply-To: <87bleizjh6.fsf@localhost> (Ihor Radchenko's message of "Fri, 25 Dec 2020 10:51:17 +0800") Message-ID: <87czyyi22y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.02 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=otTEBeRA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 90683940274 X-Spam-Score: -3.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: OiRny1tzjR7e Ihor Radchenko writes: > My current plan is supporting the overlay-based approach even after > merging the branch (by default). So, overlays should be around for a > while and the issue with drawer visibility will be around as well, > unless you fix it. I will probably work on this in distant future, but > that's not the priority now. Mmm; is the current state of your branch representative of your plan? If I compile it and run emacs -Q -L $yourbranch/lisp --eval '(setq org-startup-folded t)' $someorgfile Then isearching does not reveal logbook drawers unless matches are found inside, which as far as I am concerned fixes my issue with 9.4. >> I wonder if the path of least resistance couldn't be found in >> org-cycle-hide-drawers: right now this function just skips over drawers >> which are covered with an invisible overlay, but maybe it should not >> skip a drawer if the overlay starts before it (i.e. the overlay is not >> specific to this drawer but covers a whole containing section). > > That would defeat the purpose why the number of overlays was reduced in > Org 9.4. However, org-cycle-hide-drawers might be called in > isearch-open-invisible-temporary. Thanks for the tip.