From: Timothy <tecosaur@gmail.com>
To: "András Simonyi" <andras.simonyi@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-cite: Use citeproc-el to create CSL processor itemgetters
Date: Mon, 20 Sep 2021 20:29:35 +0800 [thread overview]
Message-ID: <87czp3ctq6.fsf@gmail.com> (raw)
In-Reply-To: <CAOWRwxAAp=G80fqrbZsU=33Q6T511jmAFyKj_tYcTCgZhrzUSg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hi András,
Great to see this patch from you 🙂.
> this is the first item in a series of oc-csl patches which I’ve
> accumulated and am planning to send this week. (My first attempt to
> send a patch, so please be patient and forgiving :-) )
This may be your first attempt sending a patch, but it all looks good to me.
Simply attaching a `.patch' file is all that’s needed, and you seem to be
following our commit message guidelines, which is good to see.
Regarding the content of this patch and the few you have planned that follow —
would it be fair to say that overall you’re trying to update `oc-csl' based on
changes you’ve made to `citeproc-el' since `oc-csl' was written?
All the best,
Timothy
next prev parent reply other threads:[~2021-09-20 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 11:56 [PATCH] org-cite: Use citeproc-el to create CSL processor itemgetters András Simonyi
2021-09-20 12:29 ` Timothy [this message]
2021-09-20 14:22 ` András Simonyi
2021-09-26 10:37 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czp3ctq6.fsf@gmail.com \
--to=tecosaur@gmail.com \
--cc=andras.simonyi@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).