From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AMwXNRb3ZWEO0QAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 22:59:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +OS1MBb3ZWFANgAAbx9fmQ (envelope-from ) for ; Tue, 12 Oct 2021 20:59:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3468E3F83B for ; Tue, 12 Oct 2021 22:59:02 +0200 (CEST) Received: from localhost ([::1]:44782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maOrU-00059R-Hn for larch@yhetil.org; Tue, 12 Oct 2021 16:59:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maOqy-00059I-Gl for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 16:58:28 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:36372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maOqw-0004hX-Ix for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 16:58:28 -0400 Received: by mail-wr1-x435.google.com with SMTP id o20so1284179wro.3 for ; Tue, 12 Oct 2021 13:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:message-id:references:date:in-reply-to :user-agent:mime-version; bh=C8tJX9UioDuqnbbA64IMxP7MNCiU9GYMnxZ4bcaPajc=; b=P8x5wCAd2JDxi3bsbBpnoaaNhKgiWpvGkO41KljOiaWEj0+gTcQnLZ8yNbgvlsUuB6 thY5NpmhWsNvdutQwqABXjgmPyyMl/icENK+z+Qj+MBoyoHOC45efVKdDvK8BCkJ6qEX bA1r4qtIWlzbFMr+MsIDRQVdWsA7TSVmkiYMoQNIwTIc32zQshFDTlycTM5apgmpXa+Y ufGUsfn0q3wf4l/f9Bv21TSLXpqM30ToaXD+VvUxYETmR0/x0inFiak358j/WKGTkhOF yCRx8XE8H6tAR7kZQbxoqvP7WjAP0mH+qIZwF39qK5gZGbwft0QJ8LCK57XgBK6eef11 Q3Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:message-id:references:date :in-reply-to:user-agent:mime-version; bh=C8tJX9UioDuqnbbA64IMxP7MNCiU9GYMnxZ4bcaPajc=; b=Z5QhT+dwGZS7ruiSFp5PmasGoFowfES6mXVihitRafMPlg+r3eFkKkbwZs9fPMlncs xWsxAZV7MdrsDiGgtfHfnqcii7TsM7bcOUUrjI8PqQdHcfXqhW14wjX0XJyYjIlromMD mb8ZKlEabOTqNkruj+7UK60GTLx2m4MG8GGcYA0Bi1mB3BKvqMIH0wNPnWWKSdKdPJXP 0tu4rHMW9zet/gRqrig1yup63mPCYe0AU4yoVdMsYPcGTrYin9tl8Magiq/6hMygD9CB C4FusdXU6VgfO+oM6WnnVNxt9YNyqh0kaiLdshJdFz2WZH/PpXcCSjaj0X99VkhmXOVt gImQ== X-Gm-Message-State: AOAM5302OxVgHF8YKQHss0fhnGS6dy+SwEJZTa9/iYBVb7OYF/pv5eFR Dhm1PNY8mifaW80+ODcbFeY= X-Google-Smtp-Source: ABdhPJy9b5gc8kJh7iC6On4Np4W8oCFr3YSFSdwGjXOGUnfHboSP40Y/bUdIZJyyIQAzixGORL+aFA== X-Received: by 2002:a5d:4601:: with SMTP id t1mr34818201wrq.298.1634072304963; Tue, 12 Oct 2021 13:58:24 -0700 (PDT) Received: from aspire-5942 (p200300d86741d100c0790b8dc06e98ee.dip0.t-ipconnect.de. [2003:d8:6741:d100:c079:b8d:c06e:98ee]) by smtp.gmail.com with ESMTPSA id p19sm3391362wmg.29.2021.10.12.13.58.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Oct 2021 13:58:24 -0700 (PDT) From: Marco Wahl To: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Message-ID: <87czoaug5x.fsf@gmail.com> References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> Date: Tue, 12 Oct 2021 22:58:09 +0200 In-Reply-To: (Max Nikulin's message of "Tue, 12 Oct 2021 21:59:23 +0700") User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=marcowahlsoft@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634072342; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C8tJX9UioDuqnbbA64IMxP7MNCiU9GYMnxZ4bcaPajc=; b=ZYPN8prl3lqzlBWd2ZKdcZl/YJp9JJPXjGW8OFwtRmIG7z0V0lNcaiA5yMDy7LcpK9HTPj wKQj6SOIxWDzQKF3HB6IKzBjOqzV3ONG2vkUMqt+Y6NEkMkqWgdnwZ8MFx3pPNBCzhs4k6 TUS8E2VEeqeO/8O51GUqj5ww1E5I+SUxkleYRZMdU/sqxT5K4MAdHxC8iJrj4xQTDBHwnW jFVZz6pNixJ702/N4Ri3RnipvvFNANCkOgbEDDbkDuyoozHDz2bmx20PnCe894XyBejC15 HAMahnKLan4iUNDkkSGdEji48a+NowXKz3minj0TueH8URKEUSPE4NBS6unCoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634072342; a=rsa-sha256; cv=none; b=DmvA6krbSdL4bCUcJDi+5fxO0RiqHIxgEiBlWA1o7SeSU2HKJFm0h82v3arzQ/GVM733wz I+8u8Ly3QNZrbZpRWdZX44SA6oTRepbsKl1QoNY6+yPOArDkg561LylKH5s9KyHkmaUVkZ QfTTauqBLRfXWGNP8/mVsIkmWo2cEC1HHiXn5MJqeiULNGorPxHEiuLHaSEGsht/Um+lxU lHSdgaukUWM0r44enj11vtsQ7OcfB0cN5cQTbQrxMs/u7lt9YT2FGXDbnL/NYsopch/nIS MIERLhDSfxhYj7yYLZ+wMlR4VITTZj4MM0LlnwlqSkudKKjQS9+QcVbd1PrzUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P8x5wCAd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P8x5wCAd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3468E3F83B X-Spam-Score: -1.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: hF5VoDugHz6f Hi Max and all! > On 08/10/2021 17:22, Marco Wahl wrote: >> Max Nikulin writes: >>> On 05/10/2021 23:32, Ihor Radchenko wrote: >>>> Max Nikulin writes: >>>> I tried come up with the reason why org-no-popup was used in the >>>> initial >>>> implementation. I think, the reason is avoiding situation like what you >>>> may see after running >>>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >>>> So, removing the macro completely is not a good idea. >>>> I have updated the patch that should work without dropping the >>>> macro. >>>> See the attached. >> >> Please note the documentation of variable `pop-up-windows'. >> >> This variable is provided mainly for backward compatibility and >> should not be used in new code. >> >> The same holds for `pop-up-frames'. >> >> The drop of the macro looks like a good idea to me. Can someone please >> describe the price for dropping macro `org-no-popups'? >> >> @Ihor I do not understand what "situation" you mean. > > Marco, have you tried > (setq pop-up-frames t) > with first version of patch? It shows help in a new separate frame. > Unsure if it is expected behavior even with such customization. > > However current version of macro does not protect against > > (setq display-buffer-base-action > '((display-buffer-reuse-window display-buffer-pop-up-frame) > (reusable-frames . 0))) > > The example is taken from (info "(elisp) Choosing Window Options"). I > have no idea if such customization can be considered as shooting a foot. TBH I don't fully understand that display-buffer stuff. I experimented a little with regards to org-goto. AFAICT org-goto does a good job without macro org-no-popups. IIUC the use of macro org-no-popups in org-goto shall "protect" the org-goto user interface in some sense. You already mentioned that. My feeling is that the "protection" is good intention but brings more harm than good. I think it's not a good idea to enforce a certain window setting. I guess the knowing user has an easier path to fine tune the org-goto user interface when there is less "protection". > http://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=399481bad10845a77f210c9320ff1efee9a312c8 > that caused the current problem changed namely `pop-up-windows' Thanks for the link! AFAICT the change in org-macs.el should not be in that commit since it has nothing to do with org links -- which are the actual concern of that commit. And indeed the change in org-macs.el of that commit broke the org-goto interface some. Summary: The org-goto interface today is somewhat broken. I vote for taking the occasion and kicking out the macro org-no-popups entirely. This way the org-goto interface is functional AFAICS. If problems occur on that path we'll take care and action. Do you agree? Regards, -- Marco