From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mBtIIs7DS2KOdgAAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 06:21:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iNX2Hs7DS2KKSAAAauVa8A (envelope-from ) for ; Tue, 05 Apr 2022 06:21:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED08A29927 for ; Tue, 5 Apr 2022 06:21:33 +0200 (CEST) Received: from localhost ([::1]:33918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbahA-00044e-Sw for larch@yhetil.org; Tue, 05 Apr 2022 00:21:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbagg-00044Q-Fw for emacs-orgmode@gnu.org; Tue, 05 Apr 2022 00:21:02 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:63636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbage-0004tz-1q for emacs-orgmode@gnu.org; Tue, 05 Apr 2022 00:21:02 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1649132453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M6Jx1oEAJq+T9ibWDWZ3oBtm9wFi7m9CMV9Eu57OIYo=; b=Ar/KCXLK53C92h6tsAOG8mQCRWnE/fivDc4EEduZv+owk8BuWsxs/etYq58SXGwhJ6Yt5R wZn2GbiV0qhQ0HIyVu3oO5YiMqivP6CQIonZVkveiDRFnmmvVyisv7pGNu+2ybZJ1PuEaN im7XmB8isfTnHHIaxPFvuhJIU37JUx3YxoJ6vrAvoLKLuvYNsAiA5HWo7y9AOX8pdl3U5e ad+8+Q3zcOGawviLE3houI/VsxmePtTghanAPoECLojiOZkDT8pFk4BmLtXfzhBPGQjHAc 73Kk/huWTdgaeH/06ZZMZX12RrPNTuEWuHGr+J5qd4dJleNHYg7Wkc9QsgnKeg== From: Kyle Meyer To: Max Nikulin Subject: Re: [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] In-Reply-To: <20e6f6ec-de72-fcdf-87a6-717efec931d1@gmail.com> References: <20e6f6ec-de72-fcdf-87a6-717efec931d1@gmail.com> Date: Tue, 05 Apr 2022 00:20:51 -0400 Message-ID: <87czhw2mak.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ignacio Casso , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649132494; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=M6Jx1oEAJq+T9ibWDWZ3oBtm9wFi7m9CMV9Eu57OIYo=; b=MxJtiijV8NLwDi5VngXJ0KiIJy3Uw0TJU+NmROtc0tOnpanRLci/DgRxq6JBBxYDo/6Fd9 dim+g4CVC879NIegtbApjOCr3SVZQ0JlQwMaM/vvUse30GZkLRoN2cZYfGgmtybYuL4utL 767RPNMiFQJOnLDNvpph6qWq2C6CgqH8dbUeOG2MiAOg3Aqct290KxqvyWXqCi+740AHwu So1ng8GXX0D+hlSbvjqjX0zd1VH8YBysiIQEQdf5pGrci0Jfizv5snMtyd13PKHdjRrBjD tvwAEjIDpBosr1vd7+Vup5I2q4kE7fkpVJS57J5PJxrn79VOxJaFK8RPlAadMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649132494; a=rsa-sha256; cv=none; b=sRjEtfOC/BbYD34lsoqZ5VN8RJAGBzznGwRrw0kcbDcwkDlh6pKnACJCMa28pbnsu3hnPg ji1xKbC3NIVpqKC15jeWvq3gsdcD33xhtNyTMgA6MviqXu2WK3Osb/He7UMUVnvQyrT+Bm hozefFT/7Iqp19PktPSGP5sOYjJnwAaUaMbiTWx0XU1Z7pkJT+GYGTC+l1iye07+WwKoUh mhM2jy/H8xmLm6sbf4B8YfjIdlYwCbT/yt9db+bOE0moj6udzYIP7fV17v6Q4mJMxSZwcE u6GpyCvUNUXFqp/DchBg22oqusGOqSi0+Spf0jlqocsHG/Z9MbXDAhpqTwBh+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="Ar/KCXLK"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="Ar/KCXLK"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: ED08A29927 X-Spam-Score: 1.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: tSt8ipRHC+tu Max Nikulin writes: > Confirmed > > Emacs copy of Org changed the way of calling `encode-time' as a result > interpretation of last nils returned by `org-parse-string' altered from > ignored to "no DST". > > Kyle, be aware of the conflict with `org-time-string-to-time' when you > will port emacs commit dd0727e1ec1f535b9b06be88173b4d3ccd55abcb > Paul Eggert Thu Dec 16 09:40:21 2021 -0800 > encode-time simplifications Thank you, Max, for looping me into the discussion (and thanks, Ignacio, for the initial report and debugging). > New calling convention for `encode-time' exists since emacs-27.1, so it > is incompatible with yet supported emacs-26. [...] >> So I guess this is an Emacs 29 bug? I didn't know the two repositories >> could diverge like that. Should I report it to Emacs 29 maintainers? >> Or can org-mode maintainers fix it in the Emacs repository? > > The problem is a consequence of grep-refactoring of Emacs code, but > likely it should be fixed at the Org side. The long tail of 9e1b9fe62 (Port more time-related changes, 2019-08-18) My suggestion: 1. Send a report to bug-gnu-emacs@gnu.org describing the issue. Ask that Paul revert those changes. I can do this at some point this week. 2. Audit and update the call sites on our side, along with some compatibility layer. The first isn't necessary, but it avoids the problem living in the Emacs master branch until the updated Org code base (main branch) is synced with it (which hasn't started yet).