From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mNvzFWsnamKzBAAAbAwnHQ (envelope-from ) for ; Thu, 28 Apr 2022 07:34:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SHYTFWsnamIXQAAAG6o9tA (envelope-from ) for ; Thu, 28 Apr 2022 07:34:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C644F82C8 for ; Thu, 28 Apr 2022 07:34:34 +0200 (CEST) Received: from localhost ([::1]:58790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njwnR-0002Vj-2Z for larch@yhetil.org; Thu, 28 Apr 2022 01:34:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njwlv-0002D7-Ue for emacs-orgmode@gnu.org; Thu, 28 Apr 2022 01:33:00 -0400 Received: from ciao.gmane.io ([116.202.254.214]:55686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njwlr-0001I1-Kv for emacs-orgmode@gnu.org; Thu, 28 Apr 2022 01:32:56 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1njwlm-0001EE-Pa for emacs-orgmode@gnu.org; Thu, 28 Apr 2022 07:32:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Eric Abrahamsen Subject: Bug in orgalist mode's advice on indent-according-to-mode Date: Wed, 27 Apr 2022 22:32:40 -0700 Message-ID: <87czh1g4cn.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:v7tVleVfur595apbaaY3gCzZsX4= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651124075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Fnw2RY5oFUMsTxJceGNQFy7Kj2jBRTJWHyeOlHcjNX0=; b=eh9uQxeif8shNP5vlMzq81Si4N7oxLVCq25CRXnLoP3uU6zoxsydN1mXe5Bs89h99atXpB jwGFThkZJq4/zH6RPW2NSKNY82SMV5PZuNomKiaY5beAOsrgIdXWob6i+MGvO80+/fmoJ7 uknvO+Cr62ZVsGGZT09zivKKZJ9mY7V05aqDowsLblWzB/qkGeacw55CK93guiEbSqsFEG 2xZSTaFdUFlRkjl3RcHPOTYoHphuMY1WJbOr7IIyzqep4QbBvlWkicD4jggfddy+zWM7Sr WHWrqKCHdYEUNFdHwhhJhps8AoeTQl8twEnf7/kmy7EcJ7XX65yYB0ajT0SFFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651124075; a=rsa-sha256; cv=none; b=fW6MXxDGdyD1gmicCpTvdImznzYFHlIypOFFNPR536e7rRGn8NjWWI71QalxWsce/t6f3N spaC2cTzcFw+rNJpttX/LtkJismkIVLgHEdzfJrxU0H8yU5V8Ui+1W1DSEywV9CP1hO9DT xWAH+cb2mOBqqk//wwIYpriYs9pEJ76gGcwFpMqri/ZJ0anM5VouHcDsik70T03w2kaHrw GW8MieqJHG3dadnfUB5HZ9psiz8Ld57ucakOQzQRMweT5sCrNafjIVR/TCRCeYGBEaV2Oe pz7+rGqrfg8Vz11THtYKArF3Vn4yIOPG4LYompd32C7OsZh2m+VETeY+52hrow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=ericabrahamsen.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.70 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=ericabrahamsen.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C644F82C8 X-Spam-Score: 2.70 X-Migadu-Scanner: scn1.migadu.com X-TUID: QM+ty/u+GYBP In Emacs commit f596f0db82c0b1ff3fe8e8f1d8b07d2fe7504ab6, from Nov 2021, the function `indent-according-to-mode' was given an optional inhibit-widen argument. That argument being passed causes orgalist's advice to fail, as the lambda doesn't accept any additional arguments. One way to fix it would be like that: (unless (advice-member-p 'orgalist-fix-bug:31361 'indent-according-to-mode) (advice-add 'indent-according-to-mode :around (lambda (old &optional inhibit-widen) "Workaround bug#31361." (or (orgalist--indent-line) (let ((indent-line-function (advice--cd*r indent-line-function))) (funcall old inhibit-widen)))) '((name . orgalist-fix-bug:31361))))) Or I suppose a more future-proof approach might be to use a &rest and then `apply' instead of `funcall'. Eric