From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MLGIO0CjgGIskAAAbAwnHQ (envelope-from ) for ; Sun, 15 May 2022 08:52:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4FRiO0CjgGKxGAAAauVa8A (envelope-from ) for ; Sun, 15 May 2022 08:52:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B7671C75B for ; Sun, 15 May 2022 08:52:48 +0200 (CEST) Received: from localhost ([::1]:38532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nq87S-0008Tl-Lr for larch@yhetil.org; Sun, 15 May 2022 02:52:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nq85B-0008SC-4G for emacs-orgmode@gnu.org; Sun, 15 May 2022 02:50:25 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:47028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nq859-0003Ms-Fz for emacs-orgmode@gnu.org; Sun, 15 May 2022 02:50:24 -0400 Received: by mail-pf1-x430.google.com with SMTP id j6so11284827pfe.13 for ; Sat, 14 May 2022 23:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=2dvUlsctY55OBfnqqP4MAfRlTRFnWpn0W4R0gMHKUEI=; b=J6jFqtgIODe57HSnqPL4c4x6n/qMaX8k7S5nQFnExI+kKIU76PkSSLWFTQby5BPj8s QEOaEg+4oGmjdDSFnadKETSc3K0gMGAJYLQ4DNbhdsoaE4EY6CLnTlISzlkb2Qj7rf0J m39wdijhioyvfOlrZPUkYEMTU5LcIOrqG+f4xN8jkmI9pBGMILsL1mCtnYlrBFtlR8aj hcYMvJmyoj+o3tVkAEWCU4GgfFQaNYcr4GFtprkYQXxUb63IQE49NR5G2zMT8eDmQMCJ mT+MySyUCAjivGKixgkzVOH2LLa8ryNvr4YMVlaUSNAgUb4pChq1WvuAFUB4NbLIu1bQ 9obw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=2dvUlsctY55OBfnqqP4MAfRlTRFnWpn0W4R0gMHKUEI=; b=RYUNbHZS95e89NCmRlI0Q0R8XS3KD/CWsds9PJhMKty0HMb6mIAgoTNu57TlE+IiVr sjDIuTAm9dCuQqUgic4rYO9aGNVTa+sPHSHu0/igQYbj8U8EHX/HFgThvbPn1GDyP62m P7D6GFvXXaalyb5hNfiy3kQoR094qAoJ77o+fizL9In9eRvxueds7OtvhLEbv74npVTR gtyCX83CSBIQFzMXQi9dhiHD4r3rooaGHpYwrdUaX0Rku9aZoFfuHeQimVkkKH2pyuWr jQmTce/DxMf2N6EQCsv1lSiYPpkakLX3C8uGrHl5xPgk9LzgUURTpj0DEZl9uhlb6tw6 bxRA== X-Gm-Message-State: AOAM532imoAfdp2OPA4WNaIe2F6dVnJk1Qgu/MxsUVlAUVoYC+dtZ6uX DyMjB67Bpyo+lQgt876gtRM= X-Google-Smtp-Source: ABdhPJzPtS1pGuTzVBWpcH/E+/EbgPIUVQDfzM6O2QxHspK1pIPEdeGOUjOJIIX/3GRPTYr1wAANlA== X-Received: by 2002:a65:5587:0:b0:3db:8693:e5f5 with SMTP id j7-20020a655587000000b003db8693e5f5mr10581502pgs.224.1652597422153; Sat, 14 May 2022 23:50:22 -0700 (PDT) Received: from localhost (61-218-132-193.hinet-ip.hinet.net. [61.218.132.193]) by smtp.gmail.com with ESMTPSA id p21-20020a1709028a9500b0015e8d4eb24asm4606946plo.148.2022.05.14.23.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 23:50:21 -0700 (PDT) From: Ihor Radchenko To: erimius@web.de Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: Bug: org-deadline drops warning periods from TIME [9.4.6 (9.4.6-10-gee652a-elpaplus @ /home/fap/.emacs.d/elpa/org-plus-contrib-20210712/)] In-Reply-To: <87o85bl582.fsf@localhost> References: <83b84e24-bf18-8b2c-0e8e-84abbd2915c8@web.de> <87o85bl582.fsf@localhost> Date: Sun, 15 May 2022 14:51:02 +0800 Message-ID: <87czgf2srt.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=yantar92@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652597568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2dvUlsctY55OBfnqqP4MAfRlTRFnWpn0W4R0gMHKUEI=; b=Bzo4RJfCbEbeNHKC7fObopTKQuqc6zUPB1HbPEe9z+4poV8xRubmQRy8oJ/ni9ANvAd+2G VyNcaiFkwJ69P4rA91FXMAnyqzE7RoCdLnRw/I6pWKCiAqP4zIhvGJ8fkQqPYfeWveGGpH SnrqCCmk4szlzVT4W3FDerihX6HnSu1KKGi/tcaZfcyCtbWVfM+xsCsA+J6KVgP44Rwtap PU+hc8pXI4HBajEzO0HDtilDJuW/mQVS8eoVq6fOUEWoKC+TFcWWofUg4H6zYTVju/Mplb ekT1/XVaVLb+QnmGrMf/K3EJBDyPwWEemO8U4bpOoRLbojmzxpgMVuXitehG0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652597568; a=rsa-sha256; cv=none; b=jMm5aQcDQ+pc0FyG3yPq9XAJ3kK2VHnfK4QA8lLZxdHSM0Dq5+DcztXz4b54L3WCwZrn40 SBdsrGQ3MnaYCte+bgsO9kqoRXSvMbyPsauw5hbip1pPJwh4MTxHpRVSO3/b7MQRHQ3KYx in+fVazrh/EhGBn3oXmJNEjISJ9jfEBgGht1oMs60gRZY+O3gnbM4aqyEQUOZc1Z+E3/PE KIButBGl8Q76EaybgcpQDORePyKFfrxiiPUUYsTojV8PNvCd9w8YQHksXo6OgRiXDXu2vr fbxGodEl6a98KHLrJT3gvo8mzVb/1QB7nwMLcKGkAy+otM8Xl0iB4ZAI43NzIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J6jFqtgI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.33 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J6jFqtgI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7B7671C75B X-Spam-Score: -5.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: zH4oINvMWqqI Ihor Radchenko writes: > erimius@web.de writes: > >> * Reproduction >> >> Call ~org-deadline~ with a warning period like so: >> >> >> (org-deadline nil "<2021-07-20 Tue -1d>") >> ;; => DEADLINE: <2021-07-20 Tue> >> >> * Expected >> >> Deadline gets added with the warning period provided. > > Can you try the attached patch? > > Also, note that warning period is still not supported when reading > deadline interactively. Not sure if we need it though. Applied onto main via cdbb1c963. I changed the patch adding support for timestamps with repeaters _and_ warning. Also, added the relevant tests. Best, Ihor