From: Ihor Radchenko <yantar92@gmail.com>
To: "Fraga, Eric" <e.fraga@ucl.ac.uk>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [BUG] org-beamer :BEAMER_ACT: ignored on columns
Date: Sat, 08 Oct 2022 14:10:50 +0800 [thread overview]
Message-ID: <87czb2luad.fsf@localhost> (raw)
In-Reply-To: <87edvjpydu.fsf@ucl.ac.uk>
"Fraga, Eric" <e.fraga@ucl.ac.uk> writes:
> On Thursday, 6 Oct 2022 at 08:01, Fraga, Eric wrote:
>> On Thursday, 6 Oct 2022 at 11:06, Ihor Radchenko wrote:
>>> Is there any reason why you only allow actions for "column" environment
>>> specifically? What about other environments?
>
> I've removed the check (not only for the new actions aspect but also for
> the options bit) and beamer export seems to work just fine. But with
> minimal testing so testing by others would be welcome.
>
> Updated patch attached.
I am reading the whole patched function now, and I feel that something is
not right.
Note the complex processing of actions below the following comment
;; If BEAMER_act property has its value enclosed in square
;; brackets, it is a default overlay specification and
;; overlay specification is empty. Otherwise, it is an
;; overlay specification and the default one is nil.
This patch certainly adds code duplication and might also miss some
scenarios considered in the environments from
org-beamer-environments-default.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-08 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41d13343-d278-2474-ba8f-88d24621ab30@housseini.me>
2022-10-05 6:38 ` [BUG] org-beamer :BEAMER_ACT: ignored on columns reza
2022-10-05 8:19 ` Fraga, Eric
2022-10-06 3:06 ` Ihor Radchenko
2022-10-06 8:01 ` Fraga, Eric
2022-10-07 13:16 ` Fraga, Eric
2022-10-08 6:10 ` Ihor Radchenko [this message]
2022-10-10 7:38 ` Fraga, Eric
2022-10-12 6:00 ` Ihor Radchenko
2022-10-12 7:42 ` Fraga, Eric
2022-10-13 2:39 ` Ihor Radchenko
2022-10-13 8:59 ` Fraga, Eric
2022-11-14 5:48 ` Ihor Radchenko
2024-01-31 14:29 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czb2luad.fsf@localhost \
--to=yantar92@gmail.com \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).