Re: [PATCH] testing: Delete duplicate tests

[Ihor Radchenko <yantar92@posteo.net>]

Ilya Chernyshov <ichernyshovvv@gmail.com> writes:

> In my last patch, I found a duplicate test, so I decided to find all of
> the duplicate tests inside testing/lisp/ folder via this function:

Thanks!

> --- a/testing/lisp/test-org-table.el
> +++ b/testing/lisp/test-org-table.el
> @@ -3368,10 +3368,6 @@ See also `test-org-table/copy-field'."
>  	  (org-test-with-temp-text "| 1 | 2 | 3 |"
>  	    (org-table-get-field 3 " foo ")
>  	    (buffer-string))))
> -  (should
> -   (equal " 4 "
> -	  (org-test-with-temp-text "| 1 | 2 |\n<point>| 3 | 4 |"
> -	    (org-table-get-field 2))))

It looks like the real test is supposed to be

(equal " foo "
...
(org-table-get-field 2 " foo ")
(buffer-string)

> --- a/testing/lisp/test-org.el
> +++ b/testing/lisp/test-org.el
> @@ -994,14 +994,6 @@
>  	      (org-auto-fill-function)
>  	      (buffer-string)))))
>    ;; Comment block: auto fill contents.
> -  (should
> -   (equal "#+BEGIN_COMMENT\n12345\n7890\n#+END_COMMENT"
> -	  (org-test-with-temp-text "#+BEGIN_COMMENT\n12345 7890\n#+END_COMMENT"
> -	    (let ((fill-column 5))
> -	      (forward-line)
> -	      (end-of-line)
> -	      (org-auto-fill-function)
> -	      (buffer-string)))))
>    (should
>     (equal "#+BEGIN_COMMENT\n12345\n7890\n#+END_COMMENT"
>  	  (org-test-with-temp-text "#+BEGIN_COMMENT\n12345 7890\n#+END_COMMENT"

And this is the result of 8a97c60
Do not fill verse blocks contents

* lisp/org.el (org-fill-context-prefix, org-fill-paragraph): Do not
  fill verse blocks contents.  Verse blocks can be used to format
  free-form poetry, so filling has to be done manually.
* testing/lisp/test-org.el: Remove unnecessary tests.

The test was changed from testing verse block into a duplicate.
I think the right thing to do here would be `should-not' + old version
of the test with VERSE block.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>