From: Olivier Lischer <olivier.lischer@liolin.ch>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-tangle: Add flag to optionally remove files before writing
Date: Wed, 28 Feb 2024 20:01:35 +0100 [thread overview]
Message-ID: <87cysgifao.fsf@liolin.ch> (raw)
In-Reply-To: <8734tc4zkc.fsf@localhost> (Ihor Radchenko's message of "Wed, 28 Feb 2024 11:07:31 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
>
> Thanks for the update!
> Unfortunately, your patch has unbalanced parenthesis and will not work.
> I have modified your patch to make things work and to make it conform to
> Elisp code conventions. I also removed spurious change in the existing
> variable.
>
> See the attached.
>
> Please, let me know if you want to change anything.
> Also, if you can, please test my patch with your use-case.
Sorry for the headache.
I tried it and it works for me.
Thank you for your patience.
next prev parent reply other threads:[~2024-02-28 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 20:25 [PATCH] ob-tangle: Add flag to optionally remove files before writing Olivier Lischer
2024-01-24 16:38 ` Ihor Radchenko
2024-01-28 19:07 ` Olivier Lischer
2024-01-28 21:11 ` Ihor Radchenko
2024-01-29 18:32 ` Olivier Lischer
2024-01-30 11:36 ` Ihor Radchenko
[not found] ` <87sf1fmwnc.fsf@localhost>
[not found] ` <87jzmrggcw.fsf@liolin.ch>
2024-02-28 11:07 ` Ihor Radchenko
2024-02-28 19:01 ` Olivier Lischer [this message]
2024-02-29 10:43 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cysgifao.fsf@liolin.ch \
--to=olivier.lischer@liolin.ch \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).