emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Lei Zhe <lzhes43@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Ensure org-table-header displays without cursor inside table
Date: Fri, 05 Apr 2024 18:39:59 +0000	[thread overview]
Message-ID: <87cyr3odq8.fsf@localhost> (raw)
In-Reply-To: <CALjq+LZP_0z0riyek0bHwqBkAJkGe3LSxEu1QDOsDZqUDUC+eg@mail.gmail.com>

Lei Zhe <lzhes43@gmail.com> writes:

> The patch ensures the header of an org-table displays without the cursor
> inside the table when org-table-header-line-mode is enabled.
>
> BTW, this is my first patch for org-mode, so please correct me if there
> are any issues with it.
> Also, I've done the paperwork before.

Thanks for the patch!
May you please explain in more details what problem you are trying to
solve?

>                   (beg (save-excursion
> +                        (goto-char ws)
>                          (goto-char (org-table-begin))
>                          (while (or (org-at-table-hline-p)
>                                     (looking-at-p ".*|\\s-+<[rcl]?\\([0-9]+\\)?>"))

Moving point to WS and then immediately to the beginning of the table
makes no difference. So, your patch does nothing.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-04-05 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 14:20 [PATCH] Ensure org-table-header displays without cursor inside table Lei Zhe
2024-04-05 18:39 ` Ihor Radchenko [this message]
     [not found]   ` <CALjq+LYwpu+Chej9ZbDV=qYGKhnTvBBeTgVvw3QV7dm-WB0WTQ@mail.gmail.com>
2024-04-06  0:29     ` Fwd: " Lei Zhe
2024-04-06 12:36     ` Ihor Radchenko
2024-04-12  9:23       ` Bastien Guerry
2024-04-12 18:05         ` Ihor Radchenko
2024-04-12 23:53           ` Lei Zhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyr3odq8.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=lzhes43@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).